-
Notifications
You must be signed in to change notification settings - Fork 54
LCORE-247: regenerated schema #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCORE-247: regenerated schema #280
Conversation
WalkthroughThe OpenAPI specification was updated to modify the default values and titles for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/openapi.json (1)
1564-1566:transcripts_enabledtitle updated but default flipped – ensure spec wording matchesThe field is now titled “Transcripts Enabled” but defaults to
false(disabled).
Confirm that accompanying documentation and UI labels reflect disabled by default rather than “enabled”.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/openapi.json(3 hunks)
🔇 Additional comments (2)
docs/openapi.json (2)
254-257: Example payload now diverges from the declared defaults – double-check intent
feedback_enabledistruehere while the schema default (see lines 1548-1550) isfalse.
If the service truly wants feedback enabled by default, either:
- keep the example as-is and flip the schema default back to
true, or- leave the schema as-is (
false) and set the example tofalseto avoid confusion.Please confirm which behaviour is correct and align example + default (and any release notes) accordingly.
1548-1550: Confirm breaking change:feedback_enableddefault flipped tofalse
File: docs/openapi.json (lines 1548–1550)"title": "Feedback Enabled", "default": falseFor clients omitting this field, feedback will now be disabled. Please verify that:
- Downstream components tolerate the new default
- The changelog or API version clearly documents this behavioral change
- If unintended, revert to
"default": trueor bump the API version
Description
LCORE-247: regenerated schema
Type of change
Related Tickets & Documents
Summary by CodeRabbit