-
Notifications
You must be signed in to change notification settings - Fork 52
LCORE-446: Use uv tool to build and upload distribution archives #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCORE-446: Use uv tool to build and upload distribution archives #319
Conversation
WalkthroughThe Makefile was updated to change the command prefix from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Makefile (1)
86-88: Consider pre-flight check before runningtwine upload
uv run python -m twine upload --repository ${PYTHON_REGISTRY} dist/*assumes:
twineis present in theuvenvironment.- The
dist/directory contains at least one file. When it’s empty, shell globbing expands to the literal stringdist/*, causing Twine to error with exit code 1.A minimal safeguard:
- uv run python -m twine upload --repository ${PYTHON_REGISTRY} dist/* + [ -n "$(ls -A dist 2>/dev/null)" ] && \ + uv run python -m twine upload --repository ${PYTHON_REGISTRY} dist/* || \ + echo "No distribution archives to upload"Not strictly required, but it prevents noisy failures in automated pipelines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Makefile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-pr
🔇 Additional comments (1)
Makefile (1)
82-85: Verifyuvenvironment has thebuildbackend installedSwitching the target to
uv run python -m buildis fine as long as thebuildpackage lives inside the environment thatuv runactivates. Double-check that:
pyproject.tomllistsbuildin[project.optional-dependencies.dev](or similar), or- Your CI job explicitly installs it via
uv pip install build.Otherwise this target will silently fail with “No module named build”.
Description
LCORE-446: Use
uvtool to build and upload distribution archivesType of change
Related Tickets & Documents
Summary by CodeRabbit