-
Notifications
You must be signed in to change notification settings - Fork 55
LCORE-336: update deps excluding Llama stack #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCORE-336: update deps excluding Llama stack #354
Conversation
WalkthroughThe version requirement for the "behave" package in the development dependencies of pyproject.toml was changed from a minimum version ("behave>=1.2.6") to an exact version ("behave==1.2.6"), enforcing the use of only version 1.2.6. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
f44976f to
72c773d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
73-73: Avoid hard-pinningbehaveunless strictly required
behave==1.2.6freezes the dev-dependency to an exact, two-year-old release while all other dev deps keep a>=floor. Hard pins hamper security patch uptake and make resolver conflicts more likely. Prefer one of:- "behave==1.2.6", + "behave>=1.2.6",or keep the exact pin but add a comment explaining the incompatibility that forces it, so future maintainers know when it can be relaxed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e_tests
Description
LCORE-336: update deps excluding Llama stack
Type of change
Related Tickets & Documents
Summary by CodeRabbit