Skip to content

Conversation

@manstis
Copy link
Contributor

@manstis manstis commented May 16, 2025

Description

I added support for invoking input-shields when defined.

I also remove the 'chat_completion_mode... what purpose did it serve; other than bypassing use of an agent`?

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks ok.

For the completion mode - it is much faster, at least on my machine, so I used it for demo purposes (did not want people to look at "reload" icon for ages during demo ;).

@tisnik
Copy link
Contributor

tisnik commented May 16, 2025

@gallettilance PTAL

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@tisnik tisnik merged commit d7b130e into lightspeed-core:main May 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants