-
Notifications
You must be signed in to change notification settings - Fork 55
Update deployment guide to use example files instead of copy and paste #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@bparees has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 26 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
1fb1b4a to
4cd1ba1
Compare
|
@tisnik @gallettilance ptal i think this will make it easier to keep the content up to date rather than having lists of deps inlined in the readme. This way the files can be reused by other docs/procedures. And maybe encourage the creation of more examples over time, if needed. (though subdirs may become necessary at some point) |
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
also moves the list of dependencies needed for running llamastack as a client, into a "localdev" group.
I debated the merits of just putting those deps under the "dev" group, but i didn't want to rock the boat. Happy to move them there if you agree that's an acceptable spot.
I'm also not sure why "uv sync --group dev" isn't a required prereq step to running lcore with lls as a client?
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing