Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Aug 27, 2025

Description

Use proper Llama Stack name in sources

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Summary by CodeRabbit

  • Style

    • Standardized capitalization from “LLama” to “Llama” across logs and error messages.
  • Documentation

    • Corrected docstrings and in-code descriptions to use “Llama Stack” consistently.
  • Tests

    • Updated test expectations and comments to match corrected messages and docstrings.
  • Chores

    • Harmonized displayed text for clearer, more professional logging and error output.

Note: No functional or behavioral changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 27, 2025

Walkthrough

Consistent capitalization changes from “LLama” to “Llama” across logging, docstrings, and error messages in endpoints, configuration, client, and associated unit tests. No functional, control-flow, API, or signature changes.

Changes

Cohort / File(s) Summary of Changes
Endpoints: logging and docstrings
src/app/endpoints/query.py, src/app/endpoints/streaming_query.py
Fixed capitalization in log messages and docstrings (“LLama” → “Llama”); no logic or control-flow changes.
Configuration messages and tests
src/models/config.py, tests/unit/models/test_config.py
Updated error message strings and corresponding test expectations/docstrings to “Llama”; no validation or behavior changes.
Client docstring
src/client.py
Corrected module/class docstring capitalization; no functional or API changes.
Endpoint tests
tests/unit/app/endpoints/test_models.py, tests/unit/app/endpoints/test_streaming_query.py
Updated expected HTTPException detail and test comments to use “Llama”; no test logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • jrobertboos
  • umago

Poem

A bunny hops through code at dawn,
Fixing names with whiskers drawn.
“LLama” trimmed to rightful “Llama” grace,
Logs and tests now wear a tidy face.
Hop, commit, and nibble a carrot—cheers! 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dfd9823 and 3fe5a26.

📒 Files selected for processing (3)
  • tests/unit/app/endpoints/test_models.py (1 hunks)
  • tests/unit/app/endpoints/test_streaming_query.py (1 hunks)
  • tests/unit/models/test_config.py (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • tests/unit/app/endpoints/test_models.py
  • tests/unit/app/endpoints/test_streaming_query.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/unit/models/test_config.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-pr
  • GitHub Check: e2e_tests
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/app/endpoints/query.py (1)

176-181: Standardize “Llama Stack” Capitalization Across the Codebase

All evidence shows we currently have three variants—

  • “LLama” (4 occurrences)
  • “Llama Stack” (229 occurrences)
  • “Llama stack” (19 occurrences)

We should pick “Llama Stack” (title-case) as the single canonical form and update every outlier.

Please address the following:

• src/app/endpoints/query.py (lines 176-181)
– Change the log from
python logger.info("Llama stack config: %s", llama_stack_config)
to
python logger.info("Llama Stack config: %s", llama_stack_config)

• tests/unit/app/endpoints/test_models.py (line 87)
– Replace
python assert e.detail["response"] == "LLama stack is not configured"
with
python assert e.detail["response"] == "Llama Stack is not configured"

• tests/unit/app/endpoints/test_streaming_query.py (line 185)
– Update the comment
python # Construct the streaming response from LLama Stack.
to
python # Construct the streaming response from Llama Stack.

• src/README.md (line 7)
– Change
md LLama Stack client retrieval class.
to
md Llama Stack client retrieval class.

• docs/rag_guide.md (line 53)
– Fix any “LLama Stack” or “Llama stack” occurrences to “Llama Stack.”

• Everywhere else
– Run a global search for “Llama stack” (lowercase s) and “LLama” and standardize to “Llama Stack.”

This will eliminate drift and keep our naming consistent.

🧹 Nitpick comments (4)
src/client.py (1)

1-1: Align naming style with endpoints and models.

This file uses “Llama Stack” (title case); elsewhere many logs/errors use “Llama stack”. Consider unifying in a sweep.

src/app/endpoints/streaming_query.py (1)

135-147: Consistent product naming across files.

This file mixes “Llama Stack” (docstrings) and “Llama stack” (logs). Suggest standardizing per style guide in a later pass.

Also applies to: 545-548

src/models/config.py (1)

192-199: Minor naming inconsistency nearby.

Here we use “Llama Stack configuration file” (title case) while errors above use “Llama stack”. Consider consolidating in a follow-up.

tests/unit/models/test_config.py (1)

115-135: Reduce brittleness of message-matching.

Long exact-phrase matches can churn on copy tweaks. Consider anchoring to stable fragments or centralizing error texts as constants.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ac278b5 and dfd9823.

📒 Files selected for processing (5)
  • src/app/endpoints/query.py (1 hunks)
  • src/app/endpoints/streaming_query.py (2 hunks)
  • src/client.py (1 hunks)
  • src/models/config.py (1 hunks)
  • tests/unit/models/test_config.py (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tests/unit/models/test_config.py (1)
src/models/config.py (1)
  • LlamaStackConfiguration (157-200)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-pr
  • GitHub Check: e2e_tests
🔇 Additional comments (6)
src/app/endpoints/query.py (1)

177-181: Corrected capitalization in log; API key redaction retained.

Looks good and keeps secrets masked.

src/client.py (1)

1-1: Docstring capitalization fixed.

Matches the PR intent.

src/app/endpoints/streaming_query.py (2)

137-147: Docstring wording updated to “Llama Stack”.

Accurate and clearer.


545-548: Log message capitalization corrected; secrets still redacted.

Good consistency with the non-streaming handler.

src/models/config.py (1)

182-195: Error messages capitalization corrected.

Matches tests and improves consistency.

tests/unit/models/test_config.py (1)

115-135: Tests updated to match new capitalization.

Looks good and aligns with model validator messages.

@tisnik tisnik force-pushed the use-proper-llama-stack-name branch from dfd9823 to 3fe5a26 Compare August 27, 2025 08:59
@tisnik tisnik merged commit d89f7a3 into lightspeed-core:main Aug 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant