-
Notifications
You must be signed in to change notification settings - Fork 54
Use proper Llama Stack name in sources #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper Llama Stack name in sources #456
Conversation
WalkthroughConsistent capitalization changes from “LLama” to “Llama” across logging, docstrings, and error messages in endpoints, configuration, client, and associated unit tests. No functional, control-flow, API, or signature changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/app/endpoints/query.py (1)
176-181: Standardize “Llama Stack” Capitalization Across the CodebaseAll evidence shows we currently have three variants—
- “LLama” (4 occurrences)
- “Llama Stack” (229 occurrences)
- “Llama stack” (19 occurrences)
We should pick “Llama Stack” (title-case) as the single canonical form and update every outlier.
Please address the following:
• src/app/endpoints/query.py (lines 176-181)
– Change the log from
python logger.info("Llama stack config: %s", llama_stack_config)
to
python logger.info("Llama Stack config: %s", llama_stack_config)• tests/unit/app/endpoints/test_models.py (line 87)
– Replace
python assert e.detail["response"] == "LLama stack is not configured"
with
python assert e.detail["response"] == "Llama Stack is not configured"• tests/unit/app/endpoints/test_streaming_query.py (line 185)
– Update the comment
python # Construct the streaming response from LLama Stack.
to
python # Construct the streaming response from Llama Stack.• src/README.md (line 7)
– Change
md LLama Stack client retrieval class.
to
md Llama Stack client retrieval class.• docs/rag_guide.md (line 53)
– Fix any “LLama Stack” or “Llama stack” occurrences to “Llama Stack.”• Everywhere else
– Run a global search for “Llama stack” (lowercase s) and “LLama” and standardize to “Llama Stack.”This will eliminate drift and keep our naming consistent.
🧹 Nitpick comments (4)
src/client.py (1)
1-1: Align naming style with endpoints and models.This file uses “Llama Stack” (title case); elsewhere many logs/errors use “Llama stack”. Consider unifying in a sweep.
src/app/endpoints/streaming_query.py (1)
135-147: Consistent product naming across files.This file mixes “Llama Stack” (docstrings) and “Llama stack” (logs). Suggest standardizing per style guide in a later pass.
Also applies to: 545-548
src/models/config.py (1)
192-199: Minor naming inconsistency nearby.Here we use “Llama Stack configuration file” (title case) while errors above use “Llama stack”. Consider consolidating in a follow-up.
tests/unit/models/test_config.py (1)
115-135: Reduce brittleness of message-matching.Long exact-phrase matches can churn on copy tweaks. Consider anchoring to stable fragments or centralizing error texts as constants.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
src/app/endpoints/query.py(1 hunks)src/app/endpoints/streaming_query.py(2 hunks)src/client.py(1 hunks)src/models/config.py(1 hunks)tests/unit/models/test_config.py(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tests/unit/models/test_config.py (1)
src/models/config.py (1)
LlamaStackConfiguration(157-200)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-pr
- GitHub Check: e2e_tests
🔇 Additional comments (6)
src/app/endpoints/query.py (1)
177-181: Corrected capitalization in log; API key redaction retained.Looks good and keeps secrets masked.
src/client.py (1)
1-1: Docstring capitalization fixed.Matches the PR intent.
src/app/endpoints/streaming_query.py (2)
137-147: Docstring wording updated to “Llama Stack”.Accurate and clearer.
545-548: Log message capitalization corrected; secrets still redacted.Good consistency with the non-streaming handler.
src/models/config.py (1)
182-195: Error messages capitalization corrected.Matches tests and improves consistency.
tests/unit/models/test_config.py (1)
115-135: Tests updated to match new capitalization.Looks good and aligns with model validator messages.
dfd9823 to
3fe5a26
Compare
Description
Use proper Llama Stack name in sources
Type of change
Summary by CodeRabbit
Style
Documentation
Tests
Chores
Note: No functional or behavioral changes.