Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Aug 28, 2025

Description

Add bandit as devel dependency

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Summary by CodeRabbit

  • Chores
    • Introduced Bandit security linter to the development toolchain to enhance static analysis during local development and CI for contributors.
    • No changes to runtime behavior, APIs, or user interface; existing functionality remains unaffected.
    • Aims to surface potential security issues earlier in the development cycle without impacting build outputs or performance in production.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

Walkthrough

Added Bandit (bandit>=1.8.6) to the development dependencies in pyproject.toml. No runtime or public API changes.

Changes

Cohort / File(s) Summary
Dev tooling update
pyproject.toml
Added Bandit (security linter) to the dev dependency group; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny taps in the twilight glow,
Adds Bandit to watch the dev fields grow.
No runtime leaps, no API show—
Just linting burrows, neat and low.
Hippity-hop, secure we go! 🐇🔍

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pyproject.toml (1)

100-101: Bandit addition looks good; consider enabling TOML config and CI/pre-commit integration.

  • Fine to add Bandit to dev deps.
  • If you intend to keep Bandit config in pyproject.toml (recommended), prefer installing the TOML extra so Bandit reliably reads it in isolated environments (e.g., pre-commit). (bandit.readthedocs.io)

Apply within this hunk:

-    "bandit>=1.8.6",
+    "bandit[toml]>=1.8.6",

Optional follow-ups (no code change required here):

  • Add a minimal config so teams know where to tweak rules, then run with “-c pyproject.toml”. Example:
[tool.bandit]
exclude_dirs = ["tests", ".venv"]
skips = ["B101"]  # allow asserts in tests

Run: uv run bandit -c pyproject.toml -r src . (bandit.readthedocs.io)

  • Wire into pre-commit or CI so it actually runs on PRs. Pre-commit example:
repos:
- repo: https://github.com/PyCQA/bandit
  rev: "1.8.6"
  hooks:
  - id: bandit
    args: ["-c", "pyproject.toml", "-r", "src"]

Note: with pre-commit you may need additional_dependencies: ["bandit[toml]"]. (bandit.readthedocs.io)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e3019d5 and 30f7dec.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-pr
  • GitHub Check: e2e_tests

@tisnik tisnik merged commit 72c0428 into lightspeed-core:main Aug 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant