-
Notifications
You must be signed in to change notification settings - Fork 54
Add bandit as devel dependency #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bandit as devel dependency #462
Conversation
WalkthroughAdded Bandit (bandit>=1.8.6) to the development dependencies in pyproject.toml. No runtime or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
100-101: Bandit addition looks good; consider enabling TOML config and CI/pre-commit integration.
- Fine to add Bandit to dev deps.
- If you intend to keep Bandit config in pyproject.toml (recommended), prefer installing the TOML extra so Bandit reliably reads it in isolated environments (e.g., pre-commit). (bandit.readthedocs.io)
Apply within this hunk:
- "bandit>=1.8.6", + "bandit[toml]>=1.8.6",Optional follow-ups (no code change required here):
- Add a minimal config so teams know where to tweak rules, then run with “-c pyproject.toml”. Example:
[tool.bandit] exclude_dirs = ["tests", ".venv"] skips = ["B101"] # allow asserts in testsRun: uv run bandit -c pyproject.toml -r src . (bandit.readthedocs.io)
- Wire into pre-commit or CI so it actually runs on PRs. Pre-commit example:
repos: - repo: https://github.com/PyCQA/bandit rev: "1.8.6" hooks: - id: bandit args: ["-c", "pyproject.toml", "-r", "src"]Note: with pre-commit you may need additional_dependencies: ["bandit[toml]"]. (bandit.readthedocs.io)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-pr
- GitHub Check: e2e_tests
Description
Add bandit as devel dependency
Type of change
Summary by CodeRabbit