LCORE-583: print all Makefile targets #477
Conversation
WalkthroughUpdated the Makefile’s help-target regex to include “/” in target names. README adds three documentation-related targets: docs/config.puml, docs/config.png, and docs/config.svg. No build logic or control flow changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (1)
570-572: Document prerequisites for docs/config. targets*Call out required tools so users don’t hit missing-binary errors when running these targets.
-docs/config.puml Generate PlantUML class diagram for configuration -docs/config.png Generate an image with configuration graph -docs/config.svg Generate an SVG with configuration graph +docs/config.puml Generate PlantUML class diagram for configuration (requires: pyreverse) +docs/config.png Generate an image with configuration graph (requires: Java + ${PATH_TO_PLANTUML}/plantuml.jar) +docs/config.svg Generate an SVG with configuration graph (requires: Java + ${PATH_TO_PLANTUML}/plantuml.jar, xmllint)Makefile (1)
108-110: Make help more robust when multiple Makefiles are listedIf $(MAKEFILE_LIST) expands to multiple files, grep will prefix matches with “filename:”, which breaks the awk formatting. Suppress filenames and optionally sort for stable output.
- @grep -E '^[ a-zA-Z0-9_./-]+:.*?## .*$$' $(MAKEFILE_LIST) | \ - awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-33s\033[0m %s\n", $$1, $$2}' + @grep -hE '^[ a-zA-Z0-9_./-]+:.*?## .*$$' $(MAKEFILE_LIST) | \ + sort | \ + awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-33s\033[0m %s\n", $$1, $$2}'To verify:
- Add include directives or a secondary Makefile and confirm “make help” still formats targets correctly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
Makefile(1 hunks)README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-pr
- GitHub Check: e2e_tests
1 participant
Description
LCORE-583: print all Makefile targets
Type of change
Related Tickets & Documents
Summary by CodeRabbit