Skip to content

fix: e2e_tests docker compose version #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

fix: e2e_tests docker compose version #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ jobs:
echo "OPENAI_API_KEY is set: $([ -n "$OPENAI_API_KEY" ] && echo 'YES' || echo 'NO')"
echo "OPENAI_API_KEY length: ${#OPENAI_API_KEY}"

Comment on lines 239 to 241
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Do not print presence/length of OPENAI_API_KEY.

Even metadata leaks aid exfiltration attempts.

-          echo "OPENAI_API_KEY is set: $([ -n "$OPENAI_API_KEY" ] && echo 'YES' || echo 'NO')"
-          echo "OPENAI_API_KEY length: ${#OPENAI_API_KEY}"
+          echo "OPENAI_API_KEY present: [redacted]"

Or remove entirely.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
echo "OPENAI_API_KEY is set: $([ -n "$OPENAI_API_KEY" ] && echo 'YES' || echo 'NO')"
echo "OPENAI_API_KEY length: ${#OPENAI_API_KEY}"
echo "OPENAI_API_KEY present: [redacted]"
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 241-241: trailing spaces

(trailing-spaces)

🤖 Prompt for AI Agents 
In .github/workflows/e2e_tests.yaml around lines 239 to 241, remove the two echo
lines that print the presence and length of OPENAI_API_KEY; do not output any
metadata about secret values. Delete those echo statements (or replace them with
a non-sensitive, generic log such as a static "OPENAI_API_KEY configured"
message that does not reveal presence, length, or any secret-derived info) to
prevent metadata leakage.

docker compose --version
docker compose version
docker compose up -d

- name: Wait for services
Expand Down