Address /query endpoint compatibility #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch add some compatibily with the /query endpoint from OLS-service. For the request itself, everything should be identical now with the exception of the "media_type" field. The "media_type" field has not been included since the current implmentantion does not yet support streaming responses. For the response to a query, there are a lot of fields missing. These also should be added as we start adding more features to Lightspeed Core. At the moment, only the basic response is returned. TODOs were left in the code pointing to those gaps. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
tisnik
reviewed
May 27, 2025
Contributor
tisnik
left a comment
tisnik
left a comment
There was a problem hiding this comment.
it looks ok in overall, I just need some time for detailed review (sorry).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch add some compatibily with the /query endpoint from OLS-service.
For the request itself, everything should be identical now with the exception of the "media_type" field. The "media_type" field has not been included since the current implmentantion does not yet support streaming responses.
For the response to a query, there are a lot of fields missing. These also should be added as we start adding more features to Lightspeed Core. At the moment, only the basic response is returned.
TODOs were left in the code pointing to those gaps.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing