Skip to content

Conversation

@radofuchs
Copy link
Contributor

@radofuchs radofuchs commented Oct 2, 2025

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • New Features

    • Added Files API for managing local file storage with metadata indexing.
    • Introduced a local filesystem provider with configurable storage directory and SQLite metadata.
    • Enabled RAG tool runtime and linked built-in RAG tools to it.
  • Chores

    • Updated default configuration to register the Files API and local filesystem provider.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Walkthrough

Added a local filesystem files provider and exposed a new files API. Introduced a rag-runtime tool runtime and linked it via tool_groups. Updated the e2e workflow to include these provider/runtime configurations.

Changes

Cohort / File(s) Summary
Workflow updates
\.github/workflows/e2e_tests.yaml
Added local filesystem provider (inline::localfs) with sqlite metadata store, introduced rag-runtime tool_runtime, linked builtin::rag via tool_groups, and included files API in the workflow config.
Runtime configuration
run.yaml
Added files API and configured providers.files (storage_dir, sqlite metadata db, provider_id localfs, provider_type inline::localfs).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client
  participant API as Files API
  participant Prov as Providers.files (localfs)
  participant Meta as Metadata Store (sqlite)
  participant Tool as Tool Runtime (rag-runtime)
  participant TG as Tool Group (builtin::rag)

  Client->>API: Invoke files operation
  API->>Prov: Read/Write file in storage_dir
  Prov-->>Meta: Record/lookup file metadata
  Meta-->>Prov: Metadata result
  Prov-->>API: File and metadata response
  Note over API,TG: For RAG-related tools
  API->>TG: Route builtin::rag tool usage
  TG->>Tool: Execute via rag-runtime
  Tool-->>API: Tool result
  API-->>Client: Combined response
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • tisnik

Poem

In burrows of bytes I hop with glee,
A local burrow—/tmp—is home to me.
I stash my files, metadata snug,
RAG tools hum along, warm and smug.
Workflows bloom, configs align—
Carrot-shaped commits, crisp and fine! 🥕📦

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title correctly references aligning run.yaml with the GitHub Actions workflow, which corresponds to the changes in both the run.yaml and the .github/workflows/e2e_tests.yaml files. It identifies a real aspect of the changeset, though it doesn’t detail the added files provider or rag-runtime entries. Overall it is concise and on-topic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d7fa44 and 5d3dd16.

📒 Files selected for processing (2)
  • .github/workflows/e2e_tests.yaml (4 hunks)
  • run.yaml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-pr
  • GitHub Check: e2e_tests
🔇 Additional comments (2)
.github/workflows/e2e_tests.yaml (1)

108-214: Config alignment looks solid

The additions wire the files API, localfs provider, rag-runtime tool runtime, and tool group mapping consistently with the in-repo run.yaml. ✅

run.yaml (1)

8-36: Files provider integration verified

files API entry and the localfs-backed providers.files block are well-formed and match the workflow configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit 0441b3e into lightspeed-core:main Oct 2, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants