-
Notifications
You must be signed in to change notification settings - Fork 52
[RHDHPAI-1150] create /v1/shields endpoint #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| """Handler for REST API call to list available shields.""" | ||
|
|
||
| import logging | ||
| from typing import Annotated, Any | ||
|
|
||
| from fastapi import APIRouter, HTTPException, Request, status | ||
| from fastapi.params import Depends | ||
| from llama_stack_client import APIConnectionError | ||
|
|
||
| from authentication import get_auth_dependency | ||
| from authentication.interface import AuthTuple | ||
| from authorization.middleware import authorize | ||
| from client import AsyncLlamaStackClientHolder | ||
| from configuration import configuration | ||
| from models.config import Action | ||
| from models.responses import ShieldsResponse | ||
| from utils.endpoints import check_configuration_loaded | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
| router = APIRouter(tags=["shields"]) | ||
|
|
||
|
|
||
| shields_responses: dict[int | str, dict[str, Any]] = { | ||
| 200: { | ||
| "shields": [ | ||
| { | ||
| "identifier": "lightspeed_question_validity-shield", | ||
| "provider_resource_id": "lightspeed_question_validity-shield", | ||
| "provider_id": "lightspeed_question_validity", | ||
| "type": "shield", | ||
| "params": {}, | ||
| } | ||
| ] | ||
| }, | ||
| 500: {"description": "Connection to Llama Stack is broken"}, | ||
| } | ||
|
|
||
|
|
||
| @router.get("/shields", responses=shields_responses) | ||
| @authorize(Action.GET_SHIELDS) | ||
| async def shields_endpoint_handler( | ||
| request: Request, | ||
| auth: Annotated[AuthTuple, Depends(get_auth_dependency())], | ||
| ) -> ShieldsResponse: | ||
| """ | ||
| Handle requests to the /shields endpoint. | ||
|
|
||
| Process GET requests to the /shields endpoint, returning a list of available | ||
| shields from the Llama Stack service. | ||
|
|
||
| Raises: | ||
| HTTPException: If unable to connect to the Llama Stack server or if | ||
| shield retrieval fails for any reason. | ||
|
|
||
| Returns: | ||
| ShieldsResponse: An object containing the list of available shields. | ||
| """ | ||
| # Used only by the middleware | ||
| _ = auth | ||
|
|
||
| # Nothing interesting in the request | ||
| _ = request | ||
|
|
||
| check_configuration_loaded(configuration) | ||
|
|
||
| llama_stack_configuration = configuration.llama_stack_configuration | ||
| logger.info("Llama stack config: %s", llama_stack_configuration) | ||
|
|
||
| try: | ||
| # try to get Llama Stack client | ||
| client = AsyncLlamaStackClientHolder().get_client() | ||
| # retrieve shields | ||
| shields = await client.shields.list() | ||
| s = [dict(s) for s in shields] | ||
| return ShieldsResponse(shields=s) | ||
|
|
||
| # connection to Llama Stack server | ||
| except APIConnectionError as e: | ||
| logger.error("Unable to connect to Llama Stack: %s", e) | ||
| raise HTTPException( | ||
| status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, | ||
| detail={ | ||
| "response": "Unable to connect to Llama Stack", | ||
| "cause": str(e), | ||
| }, | ||
| ) from e | ||
| # any other exception that can occur during shield listing | ||
| except Exception as e: | ||
| logger.error("Unable to retrieve list of shields: %s", e) | ||
| raise HTTPException( | ||
| status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, | ||
| detail={ | ||
| "response": "Unable to retrieve list of shields", | ||
| "cause": str(e), | ||
| }, | ||
| ) from e | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Import Depends from fastapi, not fastapi.params.
Aligns with project guidelines for FastAPI imports.
Apply this diff:
As per coding guidelines
📝 Committable suggestion
🤖 Prompt for AI Agents