Fix Makefile "run" target #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change introduced by the commit 023076d broke the "run" target. Without this patch, starting the service via "pdm start" would fail with the following error: $ pdm start python src/lightspeed-stack.py "run" [09:26:45] INFO Lightspeed stack startup usage: lightspeed-stack.py [-h] [-v] [-d] lightspeed-stack.py: error: unrecognized arguments: run make: *** [Makefile:6: run] Error 2 Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent change introduced by the commit
023076d broke the "run" target. Without this patch, starting the service via "pdm start" would fail with the following error:
$ pdm start
python src/lightspeed-stack.py "run"
[09:26:45] INFO Lightspeed stack startup
usage: lightspeed-stack.py [-h] [-v] [-d]
lightspeed-stack.py: error: unrecognized arguments: run
make: *** [Makefile:6: run] Error 2
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing