Skip to content

LCORE-843: fix for issues in test_dump_configuration.py #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

LCORE-843: fix for issues in test_dump_configuration.py #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/unit/models/config/test_dump_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

from pathlib import Path

from pydantic import SecretStr

from models.config import (
ModelContextProtocolServer,
Expand Down Expand Up @@ -47,7 +48,7 @@ def test_dump_configuration(tmp_path) -> None:
llama_stack=LlamaStackConfiguration(
use_as_library_client=True,
library_client_config_path="tests/configuration/run.yaml",
api_key="whatever",
api_key=SecretStr("whatever"),
),
user_data_collection=UserDataCollection(
feedback_enabled=False, feedback_storage=None
Expand All @@ -57,7 +58,7 @@ def test_dump_configuration(tmp_path) -> None:
postgres=PostgreSQLDatabaseConfiguration(
db="lightspeed_stack",
user="ls_user",
password="ls_password",
password=SecretStr("ls_password"),
port=5432,
ca_cert_path=None,
ssl_mode="require",
Expand Down Expand Up @@ -325,7 +326,7 @@ def test_dump_configuration_with_quota_limiters(tmp_path) -> None:
llama_stack=LlamaStackConfiguration(
use_as_library_client=True,
library_client_config_path="tests/configuration/run.yaml",
api_key="whatever",
api_key=SecretStr("whatever"),
),
user_data_collection=UserDataCollection(
feedback_enabled=False, feedback_storage=None
Expand All @@ -335,7 +336,7 @@ def test_dump_configuration_with_quota_limiters(tmp_path) -> None:
postgres=PostgreSQLDatabaseConfiguration(
db="lightspeed_stack",
user="ls_user",
password="ls_password",
password=SecretStr("ls_password"),
port=5432,
ca_cert_path=None,
ssl_mode="require",
Expand Down
Loading