Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions examples/lightspeed-stack-byok-rag.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Lightspeed Core Service (LCS)
service:
host: localhost
port: 8080
auth_enabled: false
workers: 1
color_log: true
access_log: true
llama_stack:
use_as_library_client: false
url: http://localhost:8321
api_key: xyzzy
user_data_collection:
feedback_enabled: true
feedback_storage: "/tmp/data/feedback"
transcripts_enabled: true
transcripts_storage: "/tmp/data/transcripts"
authentication:
module: "noop"
quota_handlers:
sqlite:
db_path: quota.sqlite
limiters:
- name: user_monthly_limits
type: user_limiter
initial_quota: 50
quota_increase: 50
period: "30 seconds"
- name: cluster_monthly_limits
type: cluster_limiter
initial_quota: 100
quota_increase: 100
period: "30 seconds"
scheduler:
# scheduler ticks in seconds
period: 10
Comment on lines +20 to +36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix period value format inconsistency (same as quota-limiter-pg).

The scheduler period (line 36) uses bare 10 while limiter periods use "30 seconds" strings. Align the format for consistency across all example configs.

  scheduler:
    # scheduler ticks in seconds
-   period: 10
+   period: "10 seconds"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
quota_handlers:
sqlite:
db_path: quota.sqlite
limiters:
- name: user_monthly_limits
type: user_limiter
initial_quota: 50
quota_increase: 50
period: "30 seconds"
- name: cluster_monthly_limits
type: cluster_limiter
initial_quota: 100
quota_increase: 100
period: "30 seconds"
scheduler:
# scheduler ticks in seconds
period: 10
quota_handlers:
sqlite:
db_path: quota.sqlite
limiters:
- name: user_monthly_limits
type: user_limiter
initial_quota: 50
quota_increase: 50
period: "30 seconds"
- name: cluster_monthly_limits
type: cluster_limiter
initial_quota: 100
quota_increase: 100
period: "30 seconds"
scheduler:
# scheduler ticks in seconds
period: "10 seconds"
🤖 Prompt for AI Agents
In examples/lightspeed-stack-byok-rag.yaml around lines 20 to 36, the scheduler
period value uses a bare numeric 10 while limiter periods use string durations
like "30 seconds"; update the scheduler period to match the same string duration
format (e.g., "10 seconds") for consistency across example configs.

byok_rag:
- rag_id: ocp_docs
rag_type: inline::faiss
embedding_dimension: 1024
vector_db_id: vector_byok_1
db_path: /tmp/ocp.faiss
- rag_id: knowledge_base
rag_type: inline::faiss
embedding_dimension: 384
vector_db_id: vector_byok_2
db_path: /tmp/kb.faiss
27 changes: 27 additions & 0 deletions examples/lightspeed-stack-conversation-cache-pg.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Lightspeed Core Service (LCS)
service:
host: localhost
port: 8080
auth_enabled: false
workers: 1
color_log: true
access_log: true
llama_stack:
use_as_library_client: true
library_client_config_path: run.yaml
user_data_collection:
feedback_enabled: true
feedback_storage: "/tmp/data/feedback"
transcripts_enabled: true
transcripts_storage: "/tmp/data/transcripts"
authentication:
module: "noop"
conversation_cache:
type: "postgres"
postgres:
host: 127.0.0.1
db: test
user: tester
password: 123qwe
ssl_mode: disable
gss_encmode: disable
22 changes: 22 additions & 0 deletions examples/lightspeed-stack-conversation-cache-sqlite.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Lightspeed Core Service (LCS)
service:
host: localhost
port: 8080
auth_enabled: false
workers: 1
color_log: true
access_log: true
llama_stack:
use_as_library_client: true
library_client_config_path: run.yaml
user_data_collection:
feedback_enabled: true
feedback_storage: "/tmp/data/feedback"
transcripts_enabled: true
transcripts_storage: "/tmp/data/transcripts"
authentication:
module: "noop"
conversation_cache:
type: "sqlite"
sqlite:
db_path: quota.sqlite
Comment on lines +19 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix YAML indentation inconsistency.

Line 22 uses 6 spaces of indentation instead of 4. For consistency with standard YAML conventions and the PostgreSQL variants (e.g., lightspeed-stack-conversation-cache-pg.yaml), nested keys should use 2-space increments.

  conversation_cache:
    type: "sqlite"
    sqlite:
-      db_path: quota.sqlite
+    db_path: quota.sqlite
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
conversation_cache:
type: "sqlite"
sqlite:
db_path: quota.sqlite
conversation_cache:
type: "sqlite"
sqlite:
db_path: quota.sqlite
🤖 Prompt for AI Agents
In examples/lightspeed-stack-conversation-cache-sqlite.yaml around lines 19 to
22, the nested key indentation is inconsistent (line 22 is indented 6 spaces);
update the YAML to use 2-space increments for nested keys so that "sqlite:"
remains indented 2 spaces under "conversation_cache:" and "db_path:" is indented
4 spaces under "sqlite:" (i.e., change line 22 from 6 spaces to 4 spaces).

29 changes: 29 additions & 0 deletions examples/lightspeed-stack-mcp-servers.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Lightspeed Core Service (LCS)
service:
host: localhost
port: 8080
auth_enabled: false
workers: 1
color_log: true
access_log: true
llama_stack:
use_as_library_client: false
url: http://localhost:8321
api_key: xyzzy
user_data_collection:
feedback_enabled: true
feedback_storage: "/tmp/data/feedback"
transcripts_enabled: true
transcripts_storage: "/tmp/data/transcripts"
authentication:
module: "noop"
mcp_servers:
- name: "server1"
provider_id: "provider1"
url: "http://url.com:1"
- name: "server2"
provider_id: "provider2"
url: "http://url.com:2"
- name: "server3"
provider_id: "provider3"
url: "http://url.com:3"
42 changes: 42 additions & 0 deletions examples/lightspeed-stack-quota-limiter-pg.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: Lightspeed Core Service (LCS)
service:
host: localhost
port: 8080
auth_enabled: false
workers: 1
color_log: true
access_log: true
llama_stack:
use_as_library_client: false
url: http://localhost:8321
api_key: xyzzy
user_data_collection:
feedback_enabled: true
feedback_storage: "/tmp/data/feedback"
transcripts_enabled: true
transcripts_storage: "/tmp/data/transcripts"
authentication:
module: "noop"
quota_handlers:
postgres:
host: "127.0.0.1"
port: 5432
db: test
user: tester
password: 123qwe
ssl_mode: disable
gss_encmode: disable
limiters:
- name: user_monthly_limits
type: user_limiter
initial_quota: 50
quota_increase: 50
period: "30 seconds"
- name: cluster_monthly_limits
type: cluster_limiter
initial_quota: 100
quota_increase: 100
period: "30 seconds"
scheduler:
# scheduler ticks in seconds
period: 10
Comment on lines +34 to +42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix inconsistent period value format.

The scheduler period (line 42) uses a bare number 10 while the limiter periods (lines 34, 38) use string format "30 seconds". For consistency and clarity, align the format—either use numeric values with a clarifying comment, or use string format with units.

  scheduler:
    # scheduler ticks in seconds
-   period: 10
+   period: "10 seconds"

Alternatively, if the schema expects numeric values only in this context, update the limiter periods to match:

    - name: user_monthly_limits
      type: user_limiter
      initial_quota: 50
      quota_increase: 50
-     period: "30 seconds"
+     period: 30
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
period: "30 seconds"
- name: cluster_monthly_limits
type: cluster_limiter
initial_quota: 100
quota_increase: 100
period: "30 seconds"
scheduler:
# scheduler ticks in seconds
period: 10
period: "30 seconds"
- name: cluster_monthly_limits
type: cluster_limiter
initial_quota: 100
quota_increase: 100
period: "30 seconds"
scheduler:
# scheduler ticks in seconds
period: "10 seconds"
🤖 Prompt for AI Agents
In examples/lightspeed-stack-quota-limiter-pg.yaml around lines 34 to 42, the
scheduler period uses a bare number (10) while the limiter periods use string
values ("30 seconds"); make formats consistent by changing the scheduler period
to the same string format — replace 10 with "10 seconds" (or alternatively
convert the limiter periods to numeric seconds if the schema requires numbers)
so all period fields use the same type and unit.

36 changes: 36 additions & 0 deletions examples/lightspeed-stack-quota-limiter-sqlite.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: Lightspeed Core Service (LCS)
service:
host: localhost
port: 8080
auth_enabled: false
workers: 1
color_log: true
access_log: true
llama_stack:
use_as_library_client: false
url: http://localhost:8321
api_key: xyzzy
user_data_collection:
feedback_enabled: true
feedback_storage: "/tmp/data/feedback"
transcripts_enabled: true
transcripts_storage: "/tmp/data/transcripts"
authentication:
module: "noop"
quota_handlers:
sqlite:
db_path: quota.sqlite
Comment on lines +20 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix YAML indentation consistency (SQLite block).

Line 22 uses 6 spaces indentation, inconsistent with standard 4-space YAML nesting. This matches the issue in lightspeed-stack-conversation-cache-sqlite.yaml. Ensure all nested keys follow 2-space increments.

  quota_handlers:
    sqlite:
-      db_path: quota.sqlite
+    db_path: quota.sqlite

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In examples/lightspeed-stack-quota-limiter-sqlite.yaml around lines 20–22, the
db_path line is indented with 6 spaces which is inconsistent; change the YAML
indentation so nested keys use 2-space increments (i.e., "sqlite:" indented 2
spaces under "quota_handlers:" and "db_path:" indented 2 spaces further under
"sqlite:") to make indentation consistent with the other YAML examples.

limiters:
- name: user_monthly_limits
type: user_limiter
initial_quota: 50
quota_increase: 50
period: "30 seconds"
- name: cluster_monthly_limits
type: cluster_limiter
initial_quota: 100
quota_increase: 100
period: "30 seconds"
scheduler:
# scheduler ticks in seconds
period: 10
Comment on lines +34 to +36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix period value format inconsistency.

The scheduler period (line 36) uses bare 10 while limiter periods (lines 28, 32) use "30 seconds" strings. This inconsistency appears across multiple example files. Standardize the format.

  scheduler:
    # scheduler ticks in seconds
-   period: 10
+   period: "30 seconds"  # or align to numeric format across all examples
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
scheduler:
# scheduler ticks in seconds
period: 10
scheduler:
# scheduler ticks in seconds
period: "10 seconds"
🤖 Prompt for AI Agents
In examples/lightspeed-stack-quota-limiter-sqlite.yaml around lines 34 to 36,
the scheduler period is written as a bare number (10) while other periods in the
file use string durations like "30 seconds"; update the scheduler period to the
same string duration format (e.g., "10 seconds") so all period values are
consistent, quoted, and parsable as durations.

Loading