Refactored configuration dump into model

src/lightspeed_stack.py

@@ -6,7 +6,6 @@
 from rich.logging import RichHandler
 
 from runners.uvicorn import start_uvicorn
-from models.config import Configuration
 from configuration import configuration
 
 
@@ -40,12 +39,6 @@ def create_argument_parser() -> ArgumentParser:
     return parser
 
 
-def dump_configuration(service_configuration: Configuration) -> None:
-    """Dump actual configuration into JSON file."""
-    with open("configuration.json", "w", encoding="utf-8") as fout:
-        fout.write(service_configuration.model_dump_json(indent=4))
-
-
 def main() -> None:
     """Entry point to the web service."""
     logger.info("Lightspeed stack startup")
@@ -59,7 +52,7 @@ def main() -> None:
     )
 
     if args.dump_configuration:
-        dump_configuration(configuration.configuration)
+        configuration.configuration.dump()
     else:
         start_uvicorn(configuration.service_configuration)
     logger.info("Lightspeed stack finished")

src/models/config.py

@@ -81,3 +81,8 @@ class Configuration(BaseModel):
     service: ServiceConfiguration
     llama_stack: LLamaStackConfiguration
     user_data_collection: UserDataCollection
+
+    def dump(self, filename: str = "configuration.json") -> None:
+        """Dump actual configuration into JSON file."""
+        with open(filename, "w", encoding="utf-8") as fout:
+            fout.write(self.model_dump_json(indent=4))

tests/unit/models/test_config.py

@@ -1,8 +1,10 @@
 """Unit tests for functions defined in src/models/config.py."""
 
+import json
 import pytest
 
 from models.config import (
+    Configuration,
     LLamaStackConfiguration,
     ServiceConfiguration,
     UserDataCollection,
@@ -104,3 +106,28 @@ def test_user_data_collection_colection_disabled() -> None:
         match="feedback_storage is required when feedback is enabled",
     ):
         UserDataCollection(feedback_disabled=False, feedback_storage=None)
+
+
+def test_dump_configuration(tmp_path) -> None:
+    """Test the ability to dump configuration."""
+    cfg = Configuration(
+        name="test_name",
+        service=ServiceConfiguration(),
+        llama_stack=LLamaStackConfiguration(
+            use_as_library_client=True, library_client_config_path="foo"
+        ),
+        user_data_collection=UserDataCollection(
+            feedback_disabled=True, feedback_storage=None
+        ),
+    )
+    assert cfg is not None
+    dump_file = tmp_path / "test.json"
+    cfg.dump(dump_file)
+
+    with open(dump_file, "r", encoding="utf-8") as fin:
+        content = json.load(fin)
+        assert content is not None
+        assert "name" in content
+        assert "service" in content
+        assert "llama_stack" in content
+        assert "user_data_collection" in content