Skip to content

poc instrument loadbalancingexporter with different buckets #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

poc instrument loadbalancingexporter with different buckets #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions exporter/loadbalancingexporter/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ require (
github.com/stretchr/testify v1.8.0
go.opencensus.io v0.23.0
go.opentelemetry.io/collector v0.60.1-0.20220923151520-96e9af35c002
go.opentelemetry.io/collector/pdata v0.60.1-0.20220923151520-96e9af35c002
go.opentelemetry.io/otel v1.10.0
go.opentelemetry.io/otel/metric v0.32.1
go.opentelemetry.io/otel/sdk/metric v0.32.1
go.uber.org/atomic v1.10.0
go.uber.org/multierr v1.8.0
go.uber.org/zap v1.23.0
Expand All @@ -23,6 +25,7 @@ require (
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/golang/snappy v0.0.4 // indirect
github.com/google/go-cmp v0.5.9 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/klauspost/compress v1.15.10 // indirect
github.com/knadh/koanf v1.4.3 // indirect
Expand All @@ -35,8 +38,7 @@ require (
github.com/pelletier/go-toml v1.9.4 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.36.0 // indirect
go.opentelemetry.io/otel v1.10.0 // indirect
go.opentelemetry.io/otel/metric v0.32.1 // indirect
go.opentelemetry.io/otel/sdk v1.10.0 // indirect
go.opentelemetry.io/otel/trace v1.10.0 // indirect
golang.org/x/net v0.0.0-20220909164309-bea034e7d591 // indirect
golang.org/x/oauth2 v0.0.0-20220909003341-f21342109be1 // indirect
Expand All @@ -49,3 +51,9 @@ require (
)

replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/batchpersignal => ../../pkg/batchpersignal

replace go.opentelemetry.io/collector => /Users/gustavo.paiva/workspace/lightstep/opentelemetry-collector-contrib/../opentelemetry-collector

replace go.opentelemetry.io/collector/pdata => /Users/gustavo.paiva/workspace/lightstep/opentelemetry-collector-contrib/../null-pdata

replace go.opentelemetry.io/collector/semconv => /Users/gustavo.paiva/workspace/lightstep/opentelemetry-collector-contrib/../null-semconv
10 changes: 5 additions & 5 deletions exporter/loadbalancingexporter/go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 40 additions & 0 deletions exporter/loadbalancingexporter/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,58 @@ import (
"go.opencensus.io/stats"
"go.opencensus.io/stats/view"
"go.opencensus.io/tag"
"go.opentelemetry.io/collector/obsreport"
"go.opentelemetry.io/otel/metric/global"
"go.opentelemetry.io/otel/metric/instrument"
"go.opentelemetry.io/otel/metric/unit"
"go.opentelemetry.io/otel/sdk/metric/aggregation"
otelview "go.opentelemetry.io/otel/sdk/metric/view"
)

var (
mNumResolutions = stats.Int64("loadbalancer_num_resolutions", "Number of times the resolver triggered a new resolutions", stats.UnitDimensionless)
mNumBackends = stats.Int64("loadbalancer_num_backends", "Current number of backends in use", stats.UnitDimensionless)
mBackendLatency = stats.Int64("loadbalancer_backend_latency", "Response latency in ms for the backends", stats.UnitMilliseconds)

meter = global.Meter("loadbalancingexporter")

omBackendLatency, _ = meter.SyncInt64().Histogram(
"loadbalancer_backend_latency",
instrument.WithDescription("Response latency in ms for the backends"),
instrument.WithUnit(unit.Milliseconds),
)

endpointTagKey = tag.MustNewKey("endpoint")
successTrueMutator = tag.Upsert(tag.MustNewKey("success"), "true")
successFalseMutator = tag.Upsert(tag.MustNewKey("success"), "false")
)

func init() {
Copy link

@jpkrohling jpkrohling Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for confirming! I know this isn't a final code, but you might want to move this to the "Start" function or similar, wrapping it inside a sync.Once

Copy link

@Aneurysm9 Aneurysm9 Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the views may need to be registered in an init() function as they need to be provided to the SDK before instruments are created.

lbView, err := otelview.New(
otelview.MatchInstrumentName("loadbalancer_backend_latency"),
otelview.WithRename("loadbalancer_backend_latency_specific_buckets"),
otelview.WithSetAggregation(aggregation.ExplicitBucketHistogram{
Boundaries: []float64{0, 1, 2, 3, 4, 5, 6, 7, 8, 1000},
}),
)
if err != nil {
return
}

lbView2, err := otelview.New(
otelview.MatchInstrumentName("loadbalancer_backend_latency"),
otelview.WithRename("loadbalancer_backend_latency_different_buckets"),
otelview.WithSetAggregation(aggregation.ExplicitBucketHistogram{
Boundaries: []float64{0, 3, 5, 7, 9, 11, 1500},
}),
)
if err != nil {
return
}

obsreport.AddViews(lbView, lbView2)
}

// MetricViews return the metrics views according to given telemetry level.
func MetricViews() []*view.View {
return []*view.View{
Expand Down
24 changes: 15 additions & 9 deletions exporter/loadbalancingexporter/trace_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ import (
"go.opentelemetry.io/collector/config"
"go.opentelemetry.io/collector/consumer"
"go.opentelemetry.io/collector/exporter/otlpexporter"
"go.opentelemetry.io/collector/obsreport"
"go.opentelemetry.io/collector/pdata/ptrace"
"go.opentelemetry.io/otel/attribute"
"go.uber.org/multierr"

"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/batchpersignal"
Expand Down Expand Up @@ -121,16 +123,20 @@ func (e *traceExporterImp) consumeTrace(ctx context.Context, td ptrace.Traces) e
err = te.ConsumeTraces(ctx, td)
duration := time.Since(start)

if err == nil {
_ = stats.RecordWithTags(
ctx,
[]tag.Mutator{tag.Upsert(endpointTagKey, endpoint), successTrueMutator},
mBackendLatency.M(duration.Milliseconds()))
if obsreport.InstrumentWithOtel() {
omBackendLatency.Record(ctx, duration.Milliseconds(), attribute.String(endpointTagKey.Name(), endpoint), attribute.Bool("success", err == nil))
} else {
_ = stats.RecordWithTags(
ctx,
[]tag.Mutator{tag.Upsert(endpointTagKey, endpoint), successFalseMutator},
mBackendLatency.M(duration.Milliseconds()))
if err == nil {
_ = stats.RecordWithTags(
ctx,
[]tag.Mutator{tag.Upsert(endpointTagKey, endpoint), successTrueMutator},
mBackendLatency.M(duration.Milliseconds()))
} else {
_ = stats.RecordWithTags(
ctx,
[]tag.Mutator{tag.Upsert(endpointTagKey, endpoint), successFalseMutator},
mBackendLatency.M(duration.Milliseconds()))
}
}
}
return err
Expand Down
6 changes: 6 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,3 +991,9 @@ exclude github.com/docker/distribution v2.8.0+incompatible
// some dependencies attempt to bring something like v1.8.2-0.20220303173753-edfe657b5405, which is older than v0.38.0
// at the time of this inclusion, v0.38.0 was the latest version available (also tagged as v2.38.0)
replace github.com/prometheus/prometheus => github.com/prometheus/prometheus v0.38.0

replace go.opentelemetry.io/collector => /Users/gustavo.paiva/workspace/lightstep/opentelemetry-collector-contrib/../opentelemetry-collector

replace go.opentelemetry.io/collector/pdata => /Users/gustavo.paiva/workspace/lightstep/opentelemetry-collector-contrib/../null-pdata

replace go.opentelemetry.io/collector/semconv => /Users/gustavo.paiva/workspace/lightstep/opentelemetry-collector-contrib/../null-semconv
27 changes: 6 additions & 21 deletions go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.