Fixes error in vline related to shape label instead of annotations #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how add_vline() handles annotations, addressing the bug described in #3065
where add_vline(x=, annotation_text=...) caused a TypeError.
It refactors the logic to use the new shape.label attribute instead of creating a separate annotation, which removes the arithmetic step that caused the failure.
Why this change
Previously, add_vline created both a shape and an annotation to display text.
To position the annotation, it computed the mean/min/max of the line’s coordinates — which broke for mixed data types (e.g., strings + datetimes).
Using shape.label removes that calculation entirely and simplifies the API.
What’s included
Added helper
_coerce_shape_label_from_legacy_annotation_kwargs(kwargs)Added
_normalize_legacy_line_position_to_textposition()Updated
_process_multiple_axis_spanning_shapes()Feedback