golangci: disable nolintlint

nolintlint flags //nolint directives whose target lint check did not
report an issue at the same line, on the assumption that the directive
is now stale. In practice the underlying linters' findings are
sensitive to golangci-lint's analysis cache and analyzer scheduling,
which can vary across platforms and across PRs even when the relevant
source has not changed. The result is occasional spurious lint
failures on CI for code that nobody touched.

Disable the linter and revert the workaround that the previous commit
applied to pkg/driver/external/client/client.go.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>

Author: jandubois

.golangci.yml

@@ -22,7 +22,6 @@ linters:
   - modernize
   - nakedret
   - noctx
-  - nolintlint
   - perfsprint
   - revive
   - staticcheck

pkg/driver/external/client/client.go

@@ -32,13 +32,7 @@ func NewDriverClient(socketPath string, logger *logrus.Logger) (*DriverClient, e
 		grpc.WithTransportCredentials(insecure.NewCredentials()),
 	}
 
-	// grpc.Dial (deprecated in favour of grpc.NewClient) is intentional here
-	// for compatibility. Suppress both the staticcheck SA1019 deprecation and
-	// nolintlint's unused-directive check: which staticcheck issues survive
-	// past golangci-lint's filter pipeline depends on cache state, so the
-	// SA1019 finding can be either kept or dropped before nolintlint inspects
-	// it. Silencing nolintlint avoids a flaky lint failure across platforms.
-	//nolint:staticcheck,nolintlint // grpc.Dial used for compatibility reasons
+	//nolint:staticcheck // grpc.Dial is used for compatibility reasons
 	conn, err := grpc.Dial("unix://"+socketPath, opts...)
 	if err != nil {
 		logger.Errorf("failed to dial gRPC driver client connection: %v", err)