client: silence flaky nolintlint at the grpc.Dial directive

The //nolint:staticcheck directive at client.go:35 has been intermittently
flagged as unused by nolintlint when running on the windows-2025 lint
job, even though the underlying code, the grpc dependency, and the
directive itself are unchanged. The behaviour is sensitive to
golangci-lint's analysis cache state: master has been passing this
check, but small changes elsewhere in the module can shift the
analyzer scheduling enough that staticcheck's SA1019 deprecation
finding disappears from the input to nolintlint, which then reports
the directive as unused.

Add nolintlint to the directive so it self-suppresses, and document
the reason inline so the next person who looks at this knows why.
The grpc.Dial -> grpc.NewClient migration is a separate concern that
would remove the need for the directive entirely; out of scope here.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>

Author: jandubois

pkg/driver/external/client/client.go

@@ -32,7 +32,13 @@ func NewDriverClient(socketPath string, logger *logrus.Logger) (*DriverClient, e
 		grpc.WithTransportCredentials(insecure.NewCredentials()),
 	}
 
-	//nolint:staticcheck // grpc.Dial is used for compatibility reasons
+	// grpc.Dial (deprecated in favour of grpc.NewClient) is intentional here
+	// for compatibility. Suppress both the staticcheck SA1019 deprecation and
+	// nolintlint's unused-directive check: which staticcheck issues survive
+	// past golangci-lint's filter pipeline depends on cache state, so the
+	// SA1019 finding can be either kept or dropped before nolintlint inspects
+	// it. Silencing nolintlint avoids a flaky lint failure across platforms.
+	//nolint:staticcheck,nolintlint // grpc.Dial used for compatibility reasons
 	conn, err := grpc.Dial("unix://"+socketPath, opts...)
 	if err != nil {
 		logger.Errorf("failed to dial gRPC driver client connection: %v", err)