Skip to content

Don't configure video or keyboard devices when -display is "none" #3897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025
+11 −9
Merged

Don't configure video or keyboard devices when -display is "none" #3897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions pkg/driver/qemu/qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,16 +851,18 @@ func Cmdline(ctx context.Context, cfg Config) (exe string, args []string, err er
args = appendArgsIfNoConflict(args, "-display", display)
}

switch *y.Arch {
// FIXME: use virtio-gpu on all the architectures
case limayaml.X8664, limayaml.RISCV64:
args = append(args, "-device", "virtio-vga")
default:
args = append(args, "-device", "virtio-gpu")
if *y.Video.Display != "none" {
switch *y.Arch {
// FIXME: use virtio-gpu on all the architectures
case limayaml.X8664, limayaml.RISCV64:
args = append(args, "-device", "virtio-vga")
default:
args = append(args, "-device", "virtio-gpu")
}
args = append(args, "-device", "virtio-keyboard-pci")
args = append(args, "-device", "virtio-"+input+"-pci")
args = append(args, "-device", "qemu-xhci,id=usb-bus")
}
args = append(args, "-device", "virtio-keyboard-pci")
args = append(args, "-device", "virtio-"+input+"-pci")
args = append(args, "-device", "qemu-xhci,id=usb-bus")

// Parallel
args = append(args, "-parallel", "none")
Expand Down