Make sure we always run BATS with --errexit #4079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Sep 24, 2025
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
force-pushed
the
bats-errexit
branch
from
6515eed to
4cd7486
Compare
songponssw
pushed a commit
to songponssw/lima
that referenced
this pull request
Sep 27, 2025
Make sure we always run BATS with --errexit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to use lima-vm/bats-core@507da84 was one of the reasons to use submodules for the bats libraries.
It looks like I forgot to apply a change to enforce that we always use it, and don't have to specify it on the commandline. Without this setting, command failure in helper functions invoked via
runwill simply be ignored instead of failing the test.