add compilation support for Fedora, RHEL, and related distributions #4228

valdela1 · 2025-10-19T15:25:29Z

No description provided.

jandubois · 2025-10-19T18:05:14Z

Makefile

+CC ?= $(shell \
+       if command -v $(call to_uname_m,$(GOARCH))-linux-gnu-gcc >/dev/null 2>&1; then \
+               echo $(call to_uname_m,$(GOARCH))-linux-gnu-gcc; \
+       elif command -v $(call to_uname_m,$(GOARCH))-redhat-linux-gcc >/dev/null 2>&1; then \


If you are putting in conditional logic, can you add a final fall back to plain gcc, which is needed on e.g. openSUSE?

As far as I can tell, the cross-compilers are called something like aarch64-suse-linux-gcc? We still need to fix gcc when not cross-compiling, though... (tested with opensuse/leap:latest container, and zypper)

Fix gcc line in Makefile for Linux #3182

We still need to fix gcc when not cross-compiling, though...

That's why I suggested it as a "final fallback" so it works for make native even when cross-gcc is not installed. Maybe it would need a comment too, and should be left for a separate PR?

I will test compiling lima on opensuse leap 16

test@opensuse:~> lsb_release -a LSB Version: n/a Distributor ID: openSUSE Description: openSUSE Leap 16.0 Release: 16.0 Codename: n/a test@opensuse:~> ls -lh /usr/bin/gcc /usr/bin/gcc-15 /usr/bin/x86_64-suse-linux-gcc* lrwxrwxrwx. 1 root root 6 Mar 12 2025 /usr/bin/gcc -> gcc-15 -rwxr-xr-x. 2 root root 1.6M Jul 17 11:24 /usr/bin/gcc-15 -rwxr-xr-x. 2 root root 1.6M Jul 17 11:24 /usr/bin/x86_64-suse-linux-gcc-15

If I add a condition for just "gcc", compiling on opensuse leap 16.0 is OK. Do you want this new condition in this PR or in another ?

@valdela1 Looks like we have consensus that it will no do any harm, and can sometimes be useful (native compilation with no cross-gcc support installed), so let's add it to this PR! Thanks!

I do get compile errors, if I don't set CC and try to build for GOARCH=arm64 (on an amd64 machine)

runtime/cgo # runtime/cgo gcc_arm64.S: Assembler messages: gcc_arm64.S:30: Error: no such instruction: `stp x29,x30,[sp,' gcc_arm64.S:34: Error: too many memory references for `mov'

Basically it is using the wrong assembler. So I need to use aarch64-linux-gnu-gcc and not just gcc

Native compilation should not require any cross-gcc, but I feel that that is a separate bug.

Adding support for RHEL and SUSE, in addition to the existing Ubuntu, is good enough here.

And falling back to gcc can be a workaround, but eventually it needs to fail - when cross-compiling.

Building for the local platform should never need any cross-gcc, that is something of a "bug" today...

When my Make files get too complicated, I tend to hide the ugly bits in a shell wrapper. Maybe appropriate?

cross-cc.sh or something similar

@valdela1 Looks like we have consensus that it will no do any harm, and can sometimes be useful (native compilation with no cross-gcc support installed), so let's add it to this PR! Thanks!

done with some modifications :)

valdela1 · 2025-10-19T19:31:41Z

With this modification, compiling is OK on each distribution fully updated as of today:

Fedora 42
CentOS Stream 10
RHEL 10
Almalinux 10
Rockylinux 10
Debian 13
Ubuntu 24.04

afbjorklund · 2025-10-20T05:24:49Z

The thing to verify, is whether it can cross-compile on Linux.

# CC is required for cross-compiling on Linux.
CC = $(call to_uname_m,$(GOARCH))-linux-gnu-gcc

If not cross-compiling, we should not have to set $CC at all....

All of the variables should then have reasonable defaults?

GOOS
GOARCH
CC (~~or GOCC?~~)

But testing make native is also a good sanity test, in itself.

valdela1 · 2025-10-20T11:11:01Z

To give a bit more explications with the last modifications:

Use "CC :=" instead of "CC ?=" to ensure the correct compiler
Without this change, CC use "cc" instead of x86_64-linux-gnu-gcc, x86_64-redhat-linux-gcc or gcc.
Change order of condition, because of packages like "gcc-$ARCH-linux-gnu" on Fedora/RHEL

$ rpm -qf /usr/bin/x86_64-linux-gnu-gcc
gcc-x86_64-linux-gnu-15.2.1-1.fc42.x86_64

On Fedora/RHEL, there is a package named gcc-x86_64-linux-gnu, if installed you have this file:

$ ll /usr/bin/x86_64-linux-gnu-gcc
-rwxr-xr-x. 1 root root 1999712 13 août  02:00 /usr/bin/x86_64-linux-gnu-gcc

It's not the same as the one on Debian/Ubuntu and compilation will failed on Fedora/RHEL. I didn't find equivalent on Debian/Ubuntu, that's why I just change condition order.

valdela1 · 2025-10-20T12:47:09Z

With the last modifications, I reconfirm compiling is OK on each distribution fully updated as of today and also OpenSUSE 16.0.

AkihiroSuda · 2025-10-20T13:18:29Z

Please squash the commits
https://lima-vm.io/docs/dev/git/#squashing-commits

well as openSUSE Signed-off-by: Valentin Dela <valdela@netc.fr>

valdela1 · 2025-10-20T13:51:51Z

Please squash the commits https://lima-vm.io/docs/dev/git/#squashing-commits

hello, done :)

jandubois

Thanks, LGTM

@AkihiroSuda or @afbjorklund please merge if you approve as well!

AkihiroSuda

Thanks, fun to see that the Red Hat Linux brand still survives in Fedora 👀

AkihiroSuda · 2025-10-21T02:16:37Z

Makefile

-CC = $(call to_uname_m,$(GOARCH))-linux-gnu-gcc
+# On Debian, Ubuntu, and related distributions, compilers are named like x86_64-linux-gnu-gcc
+# On Fedora, RHEL, and related distributions, the equivalent is x86_64-redhat-linux-gcc
+# On openSUSE and as a generic fallback, gcc is used


nit: cc could be a better generic fallback

valdela1 force-pushed the add_redhat_compilation branch from 7f269ef to 7045f8b Compare October 19, 2025 15:30

jandubois reviewed Oct 19, 2025

View reviewed changes

AkihiroSuda added this to the v2.0.0 milestone Oct 20, 2025

AkihiroSuda added the cherry-pick/v1.2 label Oct 20, 2025

valdela1 marked this pull request as ready for review October 20, 2025 12:48

add compilation support for Fedora, RHEL, and related distributions, as

a5fc10e

well as openSUSE Signed-off-by: Valentin Dela <valdela@netc.fr>

valdela1 force-pushed the add_redhat_compilation branch from a7544e1 to a5fc10e Compare October 20, 2025 13:50

jandubois approved these changes Oct 20, 2025

View reviewed changes

AkihiroSuda approved these changes Oct 21, 2025

View reviewed changes

AkihiroSuda merged commit e426bf0 into lima-vm:master Oct 21, 2025
37 checks passed

AkihiroSuda reviewed Oct 21, 2025

View reviewed changes

valdela1 deleted the add_redhat_compilation branch October 21, 2025 11:30

AkihiroSuda mentioned this pull request Oct 21, 2025

makefile:use local gcc when native compiling #3774

Closed

add compilation support for Fedora, RHEL, and related distributions #4228

add compilation support for Fedora, RHEL, and related distributions #4228

Uh oh!

Conversation

valdela1 commented Oct 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

afbjorklund Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

afbjorklund Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

afbjorklund Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valdela1 commented Oct 19, 2025

Uh oh!

afbjorklund commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

valdela1 commented Oct 20, 2025

Uh oh!

valdela1 commented Oct 20, 2025

Uh oh!

AkihiroSuda commented Oct 20, 2025

Uh oh!

valdela1 commented Oct 20, 2025

Uh oh!

jandubois left a comment

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

afbjorklund Oct 19, 2025 •

edited

Loading

afbjorklund Oct 20, 2025 •

edited

Loading

afbjorklund Oct 20, 2025 •

edited

Loading

afbjorklund commented Oct 20, 2025 •

edited

Loading