For github: URLs any *.yaml file can be a redirect or symlink
#4287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Nov 4, 2025
pkg/limatmpl/github.go
Outdated
| // If filename is .lima.yaml, check if it's a symlink/redirect to another file | ||
| if path.Base(filePath) == defaultFilename { | ||
| // If filename has a .yaml extension, check if it's a symlink/redirect to another file | ||
| if strings.HasSuffix(strings.ToLower(filePath), ".yaml") { |
Member
There was a problem hiding this comment.
nit: https://pkg.go.dev/path/filepath#Ext can be used
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
force-pushed
the
github-symlinks
branch
from
7c493ec to
600f620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4222