Skip to content

Fix #4173: glob returns an error instead of an empty list #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+4 −2
Merged

Fix #4173: glob returns an error instead of an empty list #4373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions hack/bats/tests/mcp.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,7 @@ tools_call() {
}

@test 'glob returns an empty list when the pattern does not match' {
skip "see https://github.com/lima-vm/lima/issues/4173"


tools_call glob '{"pattern":"nothing.to.see"}'

run_yq '.structuredContent.matches[]' <<<"$output"
Expand Down
3 changes: 3 additions & 0 deletions pkg/mcp/toolset/filesystem.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ func (ts *ToolSet) Glob(_ context.Context,
}
pattern := path.Join(guestPath, args.Pattern)
matches, err := ts.sftp.Glob(pattern)
if matches == nil {
matches = []string{}
}
if err != nil {
return nil, nil, err
}
Expand Down
Loading