refactor: fix modernize.stringsbuilder lint issues #4376
Merged
+58
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
requested changes
Nov 19, 2025
Member
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
The changes seem ok, but I think could be improved by using fmt.Sprintf to make them easier to read.
alexandear
force-pushed
the
refactor/modernize-stringsbuilder
branch
2 times, most recently
from
23102f0 to
f5be0e6
Compare
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
alexandear
force-pushed
the
refactor/modernize-stringsbuilder
branch
from
f5be0e6 to
94c67ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4340