🌟 added invitation ui #2577

rezk2ll · 2022-10-12T15:54:53Z

invitationProcess.mp4

RomaricMourgues · 2022-10-13T07:44:05Z

For the UI of the input+select I propose to use input groups like this: https://staging-web.twake.app/storybook/index.html?path=/story/atoms-input-groups--default
I just wanted to confirm that you used this for the tabs: https://staging-web.twake.app/storybook/index.html?path=/story/molecules-tabs--default
If not please use it and if yes please add a text-center to each tab.
For some components the items are not vertically centered, to fix this a lot of time you can just use a "flex flex-row items-center" like described here: https://tailwindcss.com/docs/align-items#center
It will help for "invite as guest" stuff and also "Workspace invitation link" stuff
Make sure you use the Text atom to always have the correct text size https://staging-web.twake.app/storybook/index.html?path=/story/atoms-text--default , if you did, then nevermind, let's see once it is vertically aligned.
Make sure to have same paddings everywhere and always using the tailwind padding classes see this image (bottom is correct):

twake/backend/node/src/services/workspaces/services/workspace.ts

twake/backend/node/src/services/workspaces/web/routes.ts

* 🌟 added invitation ui * 🌟 added allow anyone by email feature * 🌟 add role check * 🌟 add invitation domain checks and implements auto join * 🛠 fixed e2e tests * 🌟 added invite domain checking * 🛠 fixed package-lock

* 🛠 Fix potential not set cache (#2554) * Fix potential not set cache * Fix minor frontend bug * Fix old mention stuff * 🛠 Minor badge fix * 🔎 Increase thumbnails size (#2556) * 🤖 Update KG sync (#2562) * Fix numbers formats * Make sure messages updates and users updates are sent * Do the same for companies and workspaces * 🛠Fix quote reply css (#2563) * 🌟 Add read only channel option (#2558) * 🌟 Add read only channel option * 🌟 Add read only in channel schema + fix update param * 🌟 Update fr.json * Delete tailwind.css~Stashed changes Co-authored-by: Romaric Mourgues <rmourgues@linagora.com> * 🌟 Forward messages (#2566) * Add forward menu * Fix #2524 * Fix #2524 * Create modal * Finish initial version * Realtime online update * Realtime online update * Fix quoted message display * 🛠 Fix online service typo (#2575) * 🛠 Fix online service typo * Remove code * 🎨 Add checkbox atom and fix avatar atom (#2576) * Add checkbox atom and fix avatar atom * Make onChange optional * Depreciate old checkbox * Fix and add translations * Fix linter * 🛠 Fix ForwardMessages modal not in modal (#2578) * 🎨 Channel settings new UI screens (#2579) * Worked on channel settings new UI screens * Some changes * Update translations and logic * Fix channel icon display * Update back to store in S3 channel thumbnail * Fix linter * Fix int tests * 🛠 Fix backend save image (#2581) * 🌟 New invitation ui (#2577) * 🌟 added invitation ui * 🌟 added allow anyone by email feature * 🌟 add role check * 🌟 add invitation domain checks and implements auto join * 🛠 fixed e2e tests * 🌟 added invite domain checking * 🛠 fixed package-lock * Update changelog.md * Update changelog.md * 📚 Update changelog.md (#2587) * 🛠 2550 fixes (#2591) * Fix all from #2550 * Fix #2549 * Fix const / let * 🛠 Do not return files that doesn't exists anymore (#2592) * Do not return files that doesn't exists anymore * Fix filter * Fix displaying the forwarded message * Fix #2593 * 🛠 Fix scrollbar on Documents (#2599) * 🛠 Fix scrollbar on documents * Fix helpbar * 📚 Testing VitePress for documentation * Fix deployment issue * Fix deployment issue (#2604) * Fix it again Co-authored-by: Oubchid <roubraim@linagora.com> Co-authored-by: Khaled Ferjani <kferjani@linagora.com>

rezk2ll force-pushed the #2552 branch 4 times, most recently from 19b576f to 02befc0 Compare October 19, 2022 14:32

rezk2ll marked this pull request as ready for review October 19, 2022 14:33

rezk2ll force-pushed the #2552 branch 3 times, most recently from d47e664 to a115770 Compare October 19, 2022 15:42

rezk2ll added 4 commits October 24, 2022 19:26

🌟 added invitation ui

559015e

🌟 added allow anyone by email feature

5bd19d3

🌟 add role check

78c7e45

🌟 add invitation domain checks and implements auto join

f2535cb

rezk2ll force-pushed the #2552 branch from c890d8d to f2535cb Compare October 24, 2022 18:26

🛠 fixed e2e tests

efe69ca

RomaricMourgues suggested changes Oct 25, 2022

View reviewed changes

twake/backend/node/src/services/workspaces/services/workspace.ts Show resolved Hide resolved

twake/backend/node/src/services/workspaces/web/routes.ts Show resolved Hide resolved

rezk2ll requested a review from RomaricMourgues October 25, 2022 10:25

🌟 added invite domain checking

d59da35

rezk2ll force-pushed the #2552 branch 3 times, most recently from 512028f to caf47e0 Compare October 25, 2022 13:26

🛠 fixed package-lock

bab359a

rezk2ll force-pushed the #2552 branch from caf47e0 to bab359a Compare October 25, 2022 13:37

RomaricMourgues merged commit 066a3fe into linagora:develop Oct 26, 2022

github-actions bot added the staging:develop label Oct 26, 2022

RomaricMourgues added the qa:ready When a PR is ready to go to QA label Oct 26, 2022

github-actions bot added staging:qa and removed qa:ready When a PR is ready to go to QA staging:develop labels Oct 26, 2022

RomaricMourgues added staging:canary and removed staging:qa labels Nov 28, 2022

RomaricMourgues added staging:main and removed staging:canary labels Mar 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌟 added invitation ui #2577

🌟 added invitation ui #2577

rezk2ll commented Oct 12, 2022 •

edited

Loading

RomaricMourgues commented Oct 13, 2022

🌟 added invitation ui #2577

🌟 added invitation ui #2577

Conversation

rezk2ll commented Oct 12, 2022 • edited Loading

RomaricMourgues commented Oct 13, 2022

rezk2ll commented Oct 12, 2022 •

edited

Loading