MAILBOX-357 Only use Mailbox APIs for MailboxEvents #2015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
commented
Dec 11, 2018
...x/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
...x/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
...n/spamassassin/src/main/java/org/apache/james/mailbox/spamassassin/SpamAssassinListener.java
Show resolved
Hide resolved
...n/spamassassin/src/main/java/org/apache/james/mailbox/spamassassin/SpamAssassinListener.java
Outdated
Show resolved
Hide resolved
...n/spamassassin/src/main/java/org/apache/james/mailbox/spamassassin/SpamAssassinListener.java
Outdated
Show resolved
Hide resolved
...x/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
...x/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
...x/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
Member
Author
|
In ListeningMessageSearchIndex, in ElasticSearchListeningMessageSearchIndexTest and remove an unused import in ElasticSearchIndexerTest. These class will be removed later on.
Specific implementation details are never accessed
This allows relying on the MailboxSessionMapperFactory for retrieving mailboxes, which are not part of the core mailbox API
This method is not part of the mailbox-api and messages will not be carried along in distributed events. AddedImpl no longer need to carry along cached messages.
…tion details to retrieve the mailbox We should rather read it from the mailbox store
This avoids a direct reference to the specific "store" objects
We now need the messages to be persisted as they are not carried along. Also, we need to re-create mappers to isolate tests between each others.
chibenwa
force-pushed
the
store-events-1
branch
from
e296c51 to
52f6f44
Compare
This host system was using two distinct Mapper factories. This causes some failures while retrieving mailboxes in the ElasticSearch indexer
mbaechler
reviewed
Dec 11, 2018
...n/spamassassin/src/main/java/org/apache/james/mailbox/spamassassin/SpamAssassinListener.java
Outdated
Show resolved
Hide resolved
...x/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
trantienduchn
approved these changes
Dec 12, 2018
mbaechler
approved these changes
Dec 12, 2018
Member
Author
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store events where used for two features:
We need to rely on Mailbox API and read mailbox/messages from the MailboxFactory.