Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

Make the naming of the obstable directory consistent with the new base class (ObsTable).

Also rename ZTFOpSim to ZTFObsTable.

@jeremykubica jeremykubica requested a review from hombit September 3, 2025 13:15
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.50%. Comparing base (4e7e3be) to head (e8983d0).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/tdastro/obstable/ztf_obstable.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files          53       53           
  Lines        3767     3767           
=======================================
  Hits         3447     3447           
  Misses        320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Before [4e7e3be] After [8933bc7] Ratio Benchmark (Parameter)
738±40μs 668±30μs ~0.91 benchmarks.TimeSuite.time_fnu_to_flam
9.43±0.5ms 9.73±0.6ms 1.03 benchmarks.TimeSuite.time_evaluate_salt3_model
33.2±0.2ms 33.6±0.4ms 1.01 benchmarks.TimeSuite.time_additive_multi_model_source
4.69±0.03ms 4.75±0.03ms 1.01 benchmarks.TimeSuite.time_lightcurve_source
8.37±0.06ms 8.41±0.06ms 1.01 benchmarks.TimeSuite.time_load_passbands
88.2±2μs 88.9±1μs 1.01 benchmarks.TimeSuite.time_make_and_evaluate_step_model
11.0±0.07ms 11.2±0.2ms 1.01 benchmarks.TimeSuite.time_make_evaluate_constant_sed_model
12.4±0.2μs 12.5±0.2μs 1.01 benchmarks.TimeSuite.time_sample_x1_from_hostmass
1.36±0.05ms 1.37±0.03ms 1.00 benchmarks.TimeSuite.time_apply_passbands
7.66±0.02ms 7.65±0.2ms 1.00 benchmarks.TimeSuite.time_apply_white_noise

Click here to view all benchmarks.

@jeremykubica jeremykubica merged commit 96c1f0e into main Sep 3, 2025
8 of 9 checks passed
@jeremykubica jeremykubica deleted the opsim_dir_rename branch September 3, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants