Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

Moves two more dependencies to be optional:

  • dust_extinction is used for to find and load models for the extinction effect.
  • extinction is a dependency of sncosmo.

@jeremykubica jeremykubica requested a review from hombit October 9, 2025 14:52
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.99%. Comparing base (7f0ff01) to head (7f5fb92).
⚠️ Report is 220 commits behind head on main.

Files with missing lines Patch % Lines
src/lightcurvelynx/effects/extinction.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   91.89%   90.99%   -0.91%     
==========================================
  Files          55       59       +4     
  Lines        4073     4773     +700     
==========================================
+ Hits         3743     4343     +600     
- Misses        330      430     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Before [6a9e4da] After [5e0da80] Ratio Benchmark (Parameter)
686±40μs 754±60μs 1.1 benchmarks.TimeSuite.time_fnu_to_flam
19.0±0.3ms 19.6±0.2ms 1.03 benchmarks.TimeSuite.time_make_and_evaluate_static_sed
19.2±0.2ms 19.6±0.3ms 1.02 benchmarks.TimeSuite.time_chained_evaluate_sed
9.41±0.2ms 9.64±0.4ms 1.02 benchmarks.TimeSuite.time_evaluate_salt3_model
87.3±1μs 89.3±1μs 1.02 benchmarks.TimeSuite.time_make_and_evaluate_step_model
45.1±0.4μs 45.9±0.8μs 1.02 benchmarks.TimeSuite.time_make_new_salt3_model
555±7μs 564±20μs 1.01 benchmarks.TimeSuite.time_apply_passbands
11.0±0.1ms 11.1±0.07ms 1.01 benchmarks.TimeSuite.time_make_evaluate_constant_sed_model
12.6±0.3μs 12.7±0.1μs 1.01 benchmarks.TimeSuite.time_sample_x1_from_hostmass
7.62±0.1ms 7.60±0.1ms 1 benchmarks.TimeSuite.time_apply_white_noise

Click here to view all benchmarks.

@jeremykubica jeremykubica merged commit 35da580 into main Oct 9, 2025
7 of 9 checks passed
@jeremykubica jeremykubica deleted the optional_deps branch October 9, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants