Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

A basic renaming of some of the LightcurveTemplateModel's data and function for clarity:

  • Change LightcurveData to LightcurveBandData because it is defined at a band level (spoiler, there will be a future PR with LightcurveSEDData
  • Rename LightcurveBandData.evaluate_sed to evaluate_bandflux because that is what it is actually doing.
  • Rename BaseLightcurveTemplateModel to BaseLightcurveBandTemplateModel

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.18%. Comparing base (fcf07a8) to head (79f1f15).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...lightcurvelynx/models/lightcurve_template_model.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          60       60           
  Lines        4857     4857           
=======================================
  Hits         4429     4429           
  Misses        428      428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Before [fcf07a8] After [7092999] Ratio Benchmark (Parameter)
19.0±0.3ms 19.3±0.4ms 1.02 benchmarks.TimeSuite.time_make_and_evaluate_static_sed
12.2±0.2μs 12.5±0.08μs 1.02 benchmarks.TimeSuite.time_sample_x1_from_hostmass
4.36±0.05ms 4.38±0.1ms 1.01 benchmarks.TimeSuite.time_evaluate_salt3_passbands
7.78±0.1ms 7.85±0.2ms 1.01 benchmarks.TimeSuite.time_load_passbands
107±1μs 108±1μs 1.01 benchmarks.TimeSuite.time_sample_x0_from_distmod
33.3±0.6ms 33.2±0.4ms 1 benchmarks.TimeSuite.time_additive_multi_model_source
9.08±0.5ms 9.10±0.6ms 1 benchmarks.TimeSuite.time_evaluate_salt3_model
678±20μs 679±40μs 1 benchmarks.TimeSuite.time_fnu_to_flam
4.61±0.09ms 4.63±0.04ms 1 benchmarks.TimeSuite.time_lightcurve_source
85.2±2μs 85.0±1μs 1 benchmarks.TimeSuite.time_make_and_evaluate_step_model

Click here to view all benchmarks.

Co-authored-by: Olivia Lynn <olynn@andrew.cmu.edu>
@jeremykubica jeremykubica merged commit b54eae2 into main Oct 27, 2025
8 of 9 checks passed
@jeremykubica jeremykubica deleted the SIMSED branch October 27, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants