-
Notifications
You must be signed in to change notification settings - Fork 3
Support reading and Querying of SIMSED models #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 91.22% 91.20% -0.02%
==========================================
Files 61 62 +1
Lines 4899 5096 +197
==========================================
+ Hits 4469 4648 +179
- Misses 430 448 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! My main concerns are about using (light)curve naming.
A demo with SNANA data would be useful, let's make an issue for that!
Co-authored-by: Konstantin Malanchev <hombit@gmail.com>
While the ultimate goal of this PR is to support reading in an querying SIMSED models, we use it as an opportunity to create a more general SED-based lightcurve class. This class will eventually replace
SplineModeland have additional readers to incorporate data from other systems. For now we just mirror the functionality of theLightcurveTemplateModelclass and add readers for SIMSED data.