Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

While the ultimate goal of this PR is to support reading in an querying SIMSED models, we use it as an opportunity to create a more general SED-based lightcurve class. This class will eventually replace SplineModel and have additional readers to incorporate data from other systems. For now we just mirror the functionality of the LightcurveTemplateModel class and add readers for SIMSED data.

@jeremykubica jeremykubica requested a review from hombit October 29, 2025 13:25
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.20%. Comparing base (72fdad4) to head (366df28).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/lightcurvelynx/models/sed_template_model.py 91.66% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   91.22%   91.20%   -0.02%     
==========================================
  Files          61       62       +1     
  Lines        4899     5096     +197     
==========================================
+ Hits         4469     4648     +179     
- Misses        430      448      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Before [6da7ad8] After [d430851] Ratio Benchmark (Parameter)
120±6μs 122±2μs 1.01 benchmarks.TimeSuite.time_evaluate_simple_linear_wavelength_model
29.4±0.3μs 29.7±0.9μs 1.01 benchmarks.TimeSuite.time_make_simple_linear_wavelength_model
33.5±0.2ms 33.4±0.3ms 1 benchmarks.TimeSuite.time_additive_multi_model_source
7.57±0.2ms 7.57±0.05ms 1 benchmarks.TimeSuite.time_apply_white_noise
19.3±0.1ms 19.3±0.2ms 1 benchmarks.TimeSuite.time_chained_evaluate_sed
4.47±0.03ms 4.49±0.04ms 1 benchmarks.TimeSuite.time_evaluate_salt3_passbands
4.79±0.06ms 4.78±0.1ms 1 benchmarks.TimeSuite.time_lightcurve_source
8.00±0.08ms 7.98±0.03ms 1 benchmarks.TimeSuite.time_load_passbands
19.5±0.5ms 19.5±0.3ms 1 benchmarks.TimeSuite.time_make_and_evaluate_static_sed
88.1±0.4μs 88.3±2μs 1 benchmarks.TimeSuite.time_make_and_evaluate_step_model

Click here to view all benchmarks.

Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! My main concerns are about using (light)curve naming.

A demo with SNANA data would be useful, let's make an issue for that!

Co-authored-by: Konstantin Malanchev <hombit@gmail.com>
@jeremykubica jeremykubica merged commit ce2a2ca into main Oct 29, 2025
8 of 9 checks passed
@jeremykubica jeremykubica deleted the SIMSED branch October 29, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants