Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

When loading SNANA type data, show a progress bar so the user can see how much time is left.

@jeremykubica jeremykubica requested a review from mi-dai October 30, 2025 16:46
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.17%. Comparing base (661e667) to head (df05b82).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files          61       61           
  Lines        5108     5112    +4     
=======================================
+ Hits         4657     4661    +4     
  Misses        451      451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Before [661e667] After [430e73b] Ratio Benchmark (Parameter)
32.6±0.4ms 33.6±0.4ms 1.03 benchmarks.TimeSuite.time_additive_multi_model_source
541±8μs 552±8μs 1.02 benchmarks.TimeSuite.time_apply_passbands
4.69±0.05ms 4.78±0.03ms 1.02 benchmarks.TimeSuite.time_lightcurve_source
8.05±0.07ms 8.23±0.04ms 1.02 benchmarks.TimeSuite.time_load_passbands
19.3±0.1ms 19.4±0.3ms 1.01 benchmarks.TimeSuite.time_make_and_evaluate_static_sed
107±2μs 109±1μs 1.01 benchmarks.TimeSuite.time_sample_x0_from_distmod
12.6±0.05μs 12.7±0.2μs 1.01 benchmarks.TimeSuite.time_sample_x1_from_hostmass
4.41±0.05ms 4.39±0.02ms 1 benchmarks.TimeSuite.time_evaluate_salt3_passbands
87.8±2μs 88.2±0.8μs 1 benchmarks.TimeSuite.time_make_and_evaluate_step_model
11.0±0.1ms 11.0±0.1ms 1 benchmarks.TimeSuite.time_make_evaluate_constant_sed_model

Click here to view all benchmarks.

@jeremykubica jeremykubica merged commit 3fcf4d3 into main Oct 30, 2025
9 checks passed
@jeremykubica jeremykubica deleted the progress_bars branch October 30, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants