Add docker CI #307
Merged
Add docker CI #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eucyt
commented
Nov 14, 2025
|
|
||
| # Install *only* the production dependencies | ||
| RUN npm ci --ignore-scripts --omit-dev | ||
| RUN npm ci --ignore-scripts --omit=dev |
Contributor
Author
There was a problem hiding this comment.
--omit=dev is correct.
| WORKDIR /app | ||
|
|
||
| RUN --mount=type=cache,target=/root/.npm-production npm ci --ignore-scripts --omit-dev | ||
| RUN --mount=type=cache,target=/root/.npm-production npm ci --ignore-scripts |
Contributor
Author
There was a problem hiding this comment.
To conduct prettier, we should install libralies without --omit=dev
mokuzon
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Docker was not able to start (most likely due to differences in the lock file caused by a mismatch in npm versions).
To make it easier to catch this kind of issue, I added Docker CI.