Get & test webhook URL #582 #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imasahiro
reviewed
Nov 13, 2020
line-bot-api-client/src/main/java/com/linecorp/bot/client/LineMessagingClient.java
Outdated
Show resolved
Hide resolved
line-bot-api-client/src/main/java/com/linecorp/bot/client/LineMessagingClient.java
Outdated
Show resolved
Hide resolved
...ge-audience/src/main/java/com/linecorp/bot/messagingapidemoapp/controller/BotController.java
Outdated
Show resolved
Hide resolved
line-bot-model/src/main/java/com/linecorp/bot/model/request/TestWebhookEndpointRequest.java
Outdated
Show resolved
Hide resolved
line-bot-model/src/main/java/com/linecorp/bot/model/response/GetWebhookEndpointResponse.java
Outdated
Show resolved
Hide resolved
line-bot-model/src/main/java/com/linecorp/bot/model/response/TestWebhookEndpointResponse.java
Outdated
Show resolved
Hide resolved
…MessagingClient.java Co-authored-by: Masahiro Ide <imasahiro9@gmail.com>
Co-authored-by: Masahiro Ide <imasahiro9@gmail.com>
imasahiro
reviewed
Nov 16, 2020
line-bot-model/src/main/java/com/linecorp/bot/model/request/TestWebhookEndpointRequest.java
Outdated
Show resolved
Hide resolved
|
Seems you didn't add import Nonnull but other part looks good to me. I will merge once CI pass |
|
This time, I removed @nullable annotation. Because we don't use jsr305 annotations in this project, yet. |
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
============================================
+ Coverage 71.83% 71.86% +0.02%
- Complexity 339 341 +2
============================================
Files 176 176
Lines 1914 1916 +2
Branches 81 81
============================================
+ Hits 1375 1377 +2
Misses 491 491
Partials 48 48
|
imasahiro
approved these changes
Nov 17, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.