-
Notifications
You must be signed in to change notification settings - Fork 44
Add bot filtering to LinearB AI integrations #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
Please mark which AI tools you used for this PR by checking the appropriate boxes:
Tip: If you want to avoid this comment in the future, you can add a label of the format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
The PR refactors bot filtering logic by extracting inline conditions into reusable variables and extends filtering to include branch-based detection. The changes are consistently applied across all files.
1 issues detected:
🧹 Maintainability - Adding branch name pattern matching introduces potential false positives for bot detection
Details: The bot filtering logic has been significantly extended to include branch-based filtering (renovate/ branches) in addition to author-based filtering. This represents a breaking change that could exclude legitimate PRs from developers who use branch names starting with 'renovate/'.
File:docs/automation-actions.md (301-301)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
| if: | ||
| - {{ not pr.draft }} | ||
| - {{ pr.author | match(list=['github-actions', '_bot_', 'dependabot', '[bot]']) | nope }} | ||
| - {{ not (is.bot_author or is.bot_branch) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Maintainability - Behavioral Change: Document this behavioral change and consider adding a configuration option to disable branch-based filtering if needed for flexibility.
| - {{ not (is.bot_author or is.bot_branch) }} | |
| - {{ not (is.bot_author or is.bot_branch) }} # Note: Branch-based bot filtering may exclude legitimate PRs with 'renovate/' prefix |
|
A screenshot of the relevant part of docs after the changes is a life saver 🛟 |
MishaKav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
✨ PR Description
Purpose: Refactor bot filtering logic in LinearB AI integrations to improve detection of automated PR sources and prevent unnecessary AI processing.
Main changes:
nopefilter with more readablenot (is.bot_author or is.bot_branch)patternGenerated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀