-
Notifications
You must be signed in to change notification settings - Fork 44
Remove duplicate on trigger from automation examples
#765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
Please mark which AI tools you used for this PR by checking the appropriate boxes:
Tip: If you want to avoid this comment in the future, you can add a label of the format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
The PR removes on triggers from automation examples but shows inconsistent patterns - some examples have triggers completely removed while others move them to the correct location within automations.
1 issues detected:
🐞 Bug - Inconsistent handling of `on` triggers across similar automation examples creates ambiguity about the correct configuration format.
Details: The automation examples for
linearb_ai_reviewandlinearb_ai_descriptionhave theirontriggers completely removed, but therun_workflow_dispatchexample shows the trigger being moved inside the automation block rather than removed entirely. This creates inconsistent documentation that may lead users to create non-functional automation configurations.
File:docs/automation-actions.md (295-295)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
|
|
||
| ```yaml+jinja title="example - inline guidelines" | ||
| automations: | ||
| linearb_ai_review: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐞 Bug - Incomplete Examples: Either move the on triggers inside each automation block (consistent with the run_workflow_dispatch pattern) or provide clear documentation explaining when triggers are needed vs when they're optional.
| linearb_ai_review: | |
| linearb_ai_review: | |
| on: | |
| - pull_request |
|
A screenshot of the relevant part of docs after the changes is a life saver 🛟 |
MishaKav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
✨ PR Description
Purpose: Remove duplicate
ontrigger definitions from automation examples in documentation to improve clarity.Main changes:
ontrigger blocks from LinearB AI review and description examplesontrigger in workflow dispatch exampleGenerated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀