Skip to content

Set root namespace for C# package as Link.Foundation.Links.Notation instead of LinkFoundation.LinksNotation #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
konard merged 4 commits into from
Oct 18, 2025
Merged

Set root namespace for C# package as Link.Foundation.Links.Notation instead of LinkFoundation.LinksNotation #128

konard merged 4 commits into from
Oct 18, 2025

Conversation

@konard
Copy link
Member

@konard konard commented Oct 18, 2025 •
edited
Loading

Summary

This PR completes the namespace transition for the C# package from LinkFoundation.LinksNotation to Link.Foundation.Links.Notation by renaming directories and files to match the namespace structure exactly.

Changes Made

  1. Directory Renaming:

    • Renamed Platform.links-notation → Link.Foundation.Links.Notation
    • Renamed Platform.links-notation.Tests → Link.Foundation.Links.Notation.Tests

  2. File Renaming:

    • Renamed Platform.links-notation.csproj → Link.Foundation.Links.Notation.csproj
    • Renamed Platform.links-notation.Tests.csproj → Link.Foundation.Links.Notation.Tests.csproj
    • Renamed Platform.links-notation.sln → Link.Foundation.Links.Notation.sln

  3. Reference Updates:

    • Updated solution file to reference new project paths
    • Updated test project's ProjectReference to point to new main project path
    • Updated GitHub workflow (csharp.yml) to use new paths
    • Added CI script path overrides to work with namespace-based directory structure
    • Updated NuGet package URL in release workflow

  4. Version: Confirmed version is set to 0.9.0 as requested

Key Improvements

Directory Structure Now Matches Namespace: The directories are now named Link.Foundation.Links.Notation (matching the namespace) instead of Platform.links-notation. This creates consistency between the code organization and the namespace structure.

CI Script Compatibility: Added sed commands in the CI workflow to override the default path patterns in the external scripts, allowing them to work with the new namespace-based directory structure.

Root Cause Analysis

The previous attempts failed because:

  1. First attempt: Used LinkFoundation.LinksNotation directories (old namespace style)
  2. Second attempt: Used Platform.links-notation directories (CI script convention)
  3. Current solution: Uses Link.Foundation.Links.Notation directories (matching namespace) with CI overrides

The CI scripts from linksplatform/Scripts expect Platform.$REPOSITORY_NAME paths, but the user requirement is to have directories match the namespace exactly. This PR satisfies both requirements by:

  • Using namespace-based directory names (Link.Foundation.Links.Notation)
  • Overriding the CI script paths with sed commands to point to the correct locations

Verification

  • ✅ Local build successful: dotnet build --configuration Release
  • ✅ All tests passing: 105 tests passed (0 failed)
  • ✅ Version set to 0.9.0 in Link.Foundation.Links.Notation.csproj
  • ✅ RootNamespace correctly set to Link.Foundation.Links.Notation in both projects
  • ✅ Directory names match namespace exactly

Fixes

Fixes #125

🤖 Generated with Claude Code

@konard
Initial commit with task details for issue #125
d06e38b 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: undefined
@konard konard self-assigned this Oct 18, 2025
@konard @claude
Rename C# project directories and files to match Platform.links-notat…
34674b4 
…ion naming convention

This commit completes the namespace transition by:
- Renaming LinkFoundation.LinksNotation directory to Platform.links-notation
- Renaming LinkFoundation.LinksNotation.Tests directory to Platform.links-notation.Tests
- Renaming all .csproj and .sln files to match new naming convention
- Updating all internal references in solution and project files
- Updating GitHub workflow to use new paths (Platform.links-notation/Platform.links-notation.csproj)

The namespace Link.Foundation.Links.Notation was already configured in the csproj files in a previous commit.
This change ensures the CI scripts (read_csharp_package_info.sh) can find the project files at the expected path: Platform.links-notation/Platform.links-notation.csproj

Fixes #125

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Set root namespace for C# package as Link.Foundation.Links.Notation instead of LinkFoundation.LinksNotation Set root namespace for C# package as Link.Foundation.Links.Notation instead of LinkFoundation.LinksNotation Oct 18, 2025
@konard konard marked this pull request as ready for review October 18, 2025 17:23
@konard
Copy link
Member Author

konard commented Oct 18, 2025

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

📎 Log file uploaded as GitHub Gist (241KB)
🔗 View complete solution draft log

Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard
Copy link
Member Author

konard commented Oct 18, 2025 •
edited
Loading

Directories for C# should include Link.Foundation.Links.Notation (be the same as namespaces in the code). Please be careful.

@konard konard marked this pull request as draft October 18, 2025 17:25
@konard
Copy link
Member Author

konard commented Oct 18, 2025

🤖 AI Work Session Started

Starting automated work session at 2025-10-18T17:25:33.528Z

The PR has been converted to draft mode while work is in progress.

This comment marks the beginning of an AI work session. Please wait working session to finish, and provide your feedback.

@konard @claude
Rename C# directories to match namespace: Link.Foundation.Links.Notation
db6a516 
This commit completes the namespace transition by renaming all directories
and files to match the Link.Foundation.Links.Notation namespace structure.

Changes:
- Renamed directories: Platform.links-notation → Link.Foundation.Links.Notation
- Renamed directories: Platform.links-notation.Tests → Link.Foundation.Links.Notation.Tests
- Renamed all .csproj and .sln files to match new directory names
- Updated solution file project references
- Updated test project's ProjectReference
- Updated CI workflow paths and package URL
- Added CI script path overrides for namespace-based directory structure

All tests passing (105/105) and build successful.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard marked this pull request as ready for review October 18, 2025 17:31
@konard
Copy link
Member Author

konard commented Oct 18, 2025

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

📎 Log file uploaded as GitHub Gist (232KB)
🔗 View complete solution draft log

Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard konard merged commit d341bf7 into main Oct 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set root namespace for C# package as Link.Foundation.Links.Notation instead of LinkFoundation.LinksNotation

2 participants

@konard