Implement padding string

[SMAH1]

I have code like sb.Append(str.PadRight(15));.
Wouldn't it be better to reduce the pressure on GC to the same extent?
See here. This is not work in this library.

[linkdotnet]

That is a good idea - let's add that.

[linkdotnet]

Done in b68ab4d

[Joy-less]

Is this not ambiguous? PadLeft(int, char) pads the entire builder, but PadLeft(ReadOnlySpan<char>, int, char) only pads the appended span. It may be clearer to rename it to something like AppendPadLeft or AppendWithPadLeft.
@linkdotnet

[linkdotnet]

That is a good input - while a breaking change probably the best course of action

[linkdotnet]

I checked the code again PadLeft(int, char) does not pad the entire builder. Both of them are appending at the end of the builder for a given input.

But maybe AppendWith is a better name overall

[Joy-less]

I checked the code again PadLeft(int, char) does not pad the entire builder. Both of them are appending at the end of the builder for a given input.

Are you sure? PadLeft(int, char) has the following code. I added comments to show my understanding of the method.

public void PadLeft(int totalWidth, char paddingChar)
{
    // Compares the desired width to the length of the builder
    if (totalWidth <= bufferPosition)
    {
        return;
    }

    // Expands the builder to the desired width
    EnsureCapacity(totalWidth);

    // Shifts the contents of the builder after the planned padding, then fills the builder to the desired width
    var padding = totalWidth - bufferPosition;
    buffer[..bufferPosition].CopyTo(buffer[padding..]);
    buffer[..padding].Fill(paddingChar);
    bufferPosition = totalWidth;
}

In comparison, PadLeft(ReadOnlySpan<char>, int, char) only pads the source string.

public void PadLeft(ReadOnlySpan<char> source, int totalWidth, char paddingChar = ' ')
{
    // Compares the desired width to the length of the source string
    if (totalWidth <= source.Length)
    {
        Append(source);
        return;
    }

    // Expands the builder to accommodate the source string padded to the desired width
    var padding = totalWidth - source.Length;
    EnsureCapacity(bufferPosition + totalWidth);

    // Appends the padding to the builder
    buffer.Slice(bufferPosition, padding).Fill(paddingChar);
    bufferPosition += padding;

    // Appends the string to the builder
    source.CopyTo(buffer[bufferPosition..]);
    bufferPosition += source.Length;
}

@linkdotnet

[Joy-less]

I think that PadLeft(ReadOnlySpan<char>, int, char) could be renamed to AppendPaddedLeft to indicate that the PaddedLeft applies to the source string not the builder. Plus, the totalWidth parameter could be renamed to sourceTotalWidth.

[linkdotnet]

You are absolutely right - sorry my mistake. Shouldn't do multiple things at once.
Let's get it renamed.