Skip to content

[GOBBLIN-10] Fix_for_#1850_and_#1851#1967

Closed
kadaan wants to merge 2 commits into
apache:masterfrom
kadaan:Fix_for_#1850
Closed

[GOBBLIN-10] Fix_for_#1850_and_#1851#1967
kadaan wants to merge 2 commits into
apache:masterfrom
kadaan:Fix_for_#1850

Conversation

@kadaan
Copy link
Copy Markdown
Contributor

@kadaan kadaan commented Jun 22, 2017

No description provided.

@kadaan kadaan changed the title DatabaseJobHistoryStore should initialize Reflections only once. Fix_for_#1850 Jun 22, 2017
@kadaan kadaan changed the title Fix_for_#1850 Fix_for_#1850_and_#1851 Jun 22, 2017
@kadaan
Copy link
Copy Markdown
Contributor Author

kadaan commented Jun 22, 2017

Fix for #1850 and #1851

@kadaan
Copy link
Copy Markdown
Contributor Author

kadaan commented Jul 20, 2017

@abti Can you get someone to look at this?

@abti
Copy link
Copy Markdown
Member

abti commented Jul 24, 2017

@kadaan will prioritize

@abti
Copy link
Copy Markdown
Member

abti commented Jul 27, 2017

Issue: https://issues.apache.org/jira/browse/GOBBLIN-10

Please update your PR title with following prefix: [GOBBLIN-10]

@kadaan kadaan changed the title Fix_for_#1850_and_#1851 [GOBBLIN-10] Fix_for_#1850_and_#1851 Jul 27, 2017
@abti
Copy link
Copy Markdown
Member

abti commented Jul 27, 2017

@abti
Copy link
Copy Markdown
Member

abti commented Jul 27, 2017

It looks good to me, so let me know when you update the diff with findbugs resolved and I will merge it in.

@kadaan
Copy link
Copy Markdown
Contributor Author

kadaan commented Jul 27, 2017

@abti Fixed the findbugs issue.

@abti
Copy link
Copy Markdown
Member

abti commented Jul 27, 2017

Thanks

@asfgit asfgit closed this in 8d297de Jul 27, 2017
@kadaan kadaan deleted the Fix_for_#1850 branch July 28, 2017 15:27
@kadaan kadaan restored the Fix_for_#1850 branch July 28, 2017 19:29
@kadaan kadaan deleted the Fix_for_#1850 branch July 28, 2017 19:33
treff7es pushed a commit to prezi/gobblin that referenced this pull request Aug 17, 2017
DatabaseJobHistoryStore should initialize
Reflections only once.

Fix findbugs error

Closes apache#1967 from kadaan/Fix_for_#1850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants