Skip to content

Conversation

@ialarmedalien
Copy link
Collaborator

Note: base branch is the branch in #476 -- that PR should be reviewed and merged first.

Some cut-n-pastage to group relevant methods and tests together in schemaview.py and its test file. Both of these moves were straight cut and paste with no edits.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.10%. Comparing base (2fe479e) to head (f346240).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   78.10%   78.10%           
=======================================
  Files          52       52           
  Lines        4512     4512           
  Branches      983      983           
=======================================
  Hits         3524     3524           
  Misses        769      769           
  Partials      219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Silvanoc Silvanoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that only code blocks have been moved.

Just in case anyone else wants to review it too git diff --color-moved is your friend for this task 😉

Base automatically changed from schemaview_detect_cycles_node_list_args to main October 22, 2025 15:41
@amc-corey-cox amc-corey-cox merged commit 65cd85e into main Oct 22, 2025
17 checks passed
@amc-corey-cox amc-corey-cox deleted the schemaview_minor_file_reorg branch October 22, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants