schemaview.py: check for a valid slot def before calling a function

[ialarmedalien]

Adding a little bit of "insurance" to some slot range functions to ensure that they check the input is the correct type before running off and performing any functions with it.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.24%. Comparing base (dccdc1f) to head (310f85b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   78.20%   78.24%   +0.03%     
==========================================
  Files          52       52              
  Lines        4525     4533       +8     
  Branches      985      988       +3     
==========================================
+ Hits         3539     3547       +8     
  Misses        768      768              
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sujaypatil96]

Adding guardrails to check that the input to some slot details fetcher methods is in fact an object of type SlotDefinition.

[Silvanoc]

LGTM, only optional improvement proposal

[Silvanoc]

Wouldn't it make sense to have a function for this purpose, since the same validation is being applied in multiple places?

I mean something like

def _validate_slot(slot, err_sfx) -> None:
    if not slot or not isinstance(slot, SlotDefinition):
        raise ValueError(
            f"A SlotDefinition must be provided to generate the {err_sfx}."
        )

BTW you are typically optimizing. I don't get why you use the variable err_msg just for a single use.

[Silvanoc]

Feel free to resolve comment, and merge, if desired

[ialarmedalien]

the err_msg thing is to make the stack trace clearer -- otherwise you get an extra line:

https://docs.astral.sh/ruff/rules/raw-string-in-exception/

You are absolutely right about optimising by creating a generic function. I don't know why I didn't do it - end of the workday, maybe?

[Silvanoc]

You're right, I forgot that recommendation 😄

[ialarmedalien]

I'm going to investigate options because as soon as I see a verification function like that, I want to make it more generic. I need to get my core work done and then I'll dedicate some time to thinking/researching argument validation.