-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): update dependencies and fix eslint errors #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependencies and fixes ESLint errors across the codebase. The changes include updates to type casting in test mocks, minor formatting adjustments in production code, and a new ESLint configuration file.
- Updated type casts in workloadUtils tests to use “unknown as jest.Mock”.
- Reformatted code in otomi-stack.ts and error.ts to improve readability and satisfy linting.
- Removed the recursive copy flag in git.ts and introduced a new ESLint configuration in eslint.config.mjs.
Reviewed Changes
Copilot reviewed 7 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/workloadUtils.test.ts | Updated type casting for fsExtra.readFile mocks. |
| src/otomi-stack.ts | Reformatted setTimeout call and removed an unnecessary eslint-disable comment. |
| src/git.ts | Removed the recursive option in the copy call. |
| src/error.ts | Reformatted the HttpError constructor for clarity. |
| eslint.config.mjs | Added a new ESLint configuration file to align with new dependency updates. |
Files not reviewed (7)
- .eslintignore: Language not supported
- .eslintrc.yml: Language not supported
- .husky/post-checkout: Language not supported
- .husky/post-merge: Language not supported
- .husky/post-rewrite: Language not supported
- .husky/pre-push: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (3)
src/git.ts:331
- The removal of the 'recursive: true' parameter in the copy call may break recursive copying; please confirm that this behavior is intentional with the updated dependency.
await copy(join(process.cwd(), 'test'), env.GIT_LOCAL_PATH, { overwrite: false, })
eslint.config.mjs:1
- The opening comment refers to the file as 'eslint.config.js' while the file extension is '.mjs'; consider updating the comment to reflect the correct file type.
// eslint.config.js
src/otomi-stack.ts:2138
- [nitpick] The removal of the eslint-disable comment might cause linting issues if the getKubecfg method doesn't use 'this'; please verify that this change does not introduce lint errors.
// eslint-disable-next-line class-methods-use-this
Coverage report
Show files with reduced coverage 🔻
Test suite run success289 tests passing in 12 suites. Report generated by 🧪jest coverage report action from 87aeccf |
ferruhcihan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.