Skip to content

Conversation

@dennisvankekem
Copy link
Collaborator

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@dennisvankekem dennisvankekem requested review from Copilot and removed request for ferruhcihan July 31, 2025 07:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the http-proxy-middleware package from version 3.0.5 to version 2.0.3 to fix issues with the HTTP proxy middleware functionality.

  • Downgrades http-proxy-middleware from v3.0.5 to v2.0.3

@dennisvankekem
Copy link
Collaborator Author

I've tried to timebox it to fix an issue for this, I've rewritten the proxy file to modern JS and according to the documentation but for some reason localhost:3000 simply refuses to connect unless http proxy middleware is specifically on 0.21.0. I will make a ticket for this and for now I'll revert the bump

Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works

@ferruhcihan ferruhcihan merged commit f1540c0 into main Jul 31, 2025
7 checks passed
@ferruhcihan ferruhcihan deleted the fix-http-proxy branch July 31, 2025 09:24
Ani1357 added a commit that referenced this pull request Jul 31, 2025
Ani1357 added a commit that referenced this pull request Jul 31, 2025
dennisvankekem pushed a commit that referenced this pull request Aug 1, 2025
* Revert "fix: http proxy middleware (#615)"

This reverts commit f1540c0.

* Revert "chore: upgrade http-proxy-middleware (#616)"

This reverts commit cffe915.

---------

Co-authored-by: svcAPLBot <174728082+svcAPLBot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants