fix: sni hosts#1658
Merged
srodenhuis merged 2 commits intomainfrom Jul 26, 2024
Merged
Conversation
Ani1357
approved these changes
Jul 25, 2024
Contributor
Ani1357
left a comment
Ani1357
left a comment
There was a problem hiding this comment.
LGTM.Tested creating service with cname in dev cluster.
Ani1357
pushed a commit
that referenced
this pull request
Sep 17, 2024
(cherry picked from commit 1642303)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the wrong
*sniHosts when aCNAMEis used. Using*is not supported anymore so we need to set the hosts