Skip to content

feat: add tini to remove zombie git processes#3114

Merged
j-zimnowoda merged 27 commits intomainfrom
APL-1766
Apr 13, 2026
Merged

feat: add tini to remove zombie git processes#3114
j-zimnowoda merged 27 commits intomainfrom
APL-1766

Conversation

@CasLubbers
Copy link
Copy Markdown
Contributor

📌 Summary

long running operator contains a lot of zombie git processes. (steveukx/git-js#1062). Recommended is to use tini so that the processes are getting cleaned up

1001     3076711  0.0  0.0      0     0 ?        Z    Mar27   0:00 [git] <defunct>
1001     3076716  0.0  0.0      0     0 ?        Z    Mar27   0:00 [git] <defunct>
1001     3076721  0.0  0.0      0     0 ?        Z    Mar27   0:00 [git] <defunct>
1001     3076726  0.0  0.0      0     0 ?        Z    Mar27   0:00 [git] <defunct>
1001     3076731  0.0  0.0      0     0 ?        Z    Mar27   0:00 [git] <defunct>
1001     3839099  0.0  0.0      0     0 ?        Z    Mar31   0:00 [git] <defunct>
1001     3839104  0.0  0.0      0     0 ?        Z    Mar31   0:00 [git] <defunct>
1001     3839109  0.0  0.0      0     0 ?        Z    Mar31   0:00 [git] <defunct>
1001     3839114  0.0  0.0      0     0 ?        Z    Mar31   0:00 [git] <defunct>
1001     3839119  0.0  0.0      0     0 ?        Z    Mar31   0:00 [git] <defunct>
1001     3839124  0.0  0.0      0     0 ?        Z    Mar31   0:00 [git] <defunct>
1001     3839129  0.0  0.0      0     0 ?        Z    Mar31   0:00 [git] <defunct>
1001     3839134  0.0  0.0      0     0 ?        Z    Mar31   0:00 [git] <defunct>
1001     3839139  0.0  0.0      0     0 ?        Z    Mar31   0:00 [git] <defunct>

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@Ani1357
Copy link
Copy Markdown
Contributor

Ani1357 commented Apr 9, 2026

updating the tools/Dockerfile will trigger the creation of a new patch version for the apl-tools(v2.10.7). This new version has to be used in the apl-core Dockerfile. We could ether:

  • update the tools/Dockerfile in this PR and update the Dockerfile in a follow-up PR
  • or update them both in this PR (also the apl-tools version in the Dockerfile) and expect the first run of the build pipeline to fail(a rerun should work in theory).

@CasLubbers
Copy link
Copy Markdown
Contributor Author

updating the tools/Dockerfile will trigger the creation of a new patch version for the apl-tools(v2.10.7). This new version has to be used in the apl-core Dockerfile. We could ether:

  • update the tools/Dockerfile in this PR and update the Dockerfile in a follow-up PR
  • or update them both in this PR (also the apl-tools version in the Dockerfile) and expect the first run of the build pipeline to fail(a rerun should work in theory).

Good one, however the fix did already work. So I am guessing tini is in the image already. We can update the tools version in the socket file afterwards

@Ani1357
Copy link
Copy Markdown
Contributor

Ani1357 commented Apr 10, 2026

The fix seems to work because you added tini to the apl-api Dockerfile. If there is no risk of encountering this issue in core, we can drop this PR.

@CasLubbers
Copy link
Copy Markdown
Contributor Author

CasLubbers commented Apr 10, 2026

The fix seems to work because you added tini to the apl-api Dockerfile. If there is no risk of encountering this issue in core, we can drop this PR.

Yes there is a risk. If you go in to the apl-operator pod can you also see the same issue. And adding this already removed those processes in there.
It will only take much longer in there. But if you never update you will run out eventually..

@j-zimnowoda j-zimnowoda merged commit 58a7aa5 into main Apr 13, 2026
13 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-1766 branch April 13, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants