Skip to content

Conversation

@sagesyr
Copy link
Contributor

@sagesyr sagesyr commented Aug 21, 2020

No description provided.

@sagesyr sagesyr requested a review from yoshizzle August 21, 2020 22:29
Copy link
Collaborator

@yoshizzle yoshizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


### Fixed
- A bug was fixed that would result in a 500 error when filtering domain records by a non-existent tag. This will now return an empty 200 respone.
- Previously, NS and CNAME records could be created for eachother, resulting in errors. If this is attempted now, the record creation will fail with a "Record conflict" message.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"each other" (two words)

Copy link
Contributor

@alsaihn alsaihn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clarification for where the NS/CNAME error previously showed up.


### Fixed
- A bug was fixed that would result in a 500 error when filtering domain records by a non-existent tag. This will now return a 200 response with an empty pagination result.
- Previously, NS and CNAME records could be created for each other, resulting in errors. If this is attempted now, the record creation will fail with a "Record conflict" message.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Previously, NS and CNAME records could be created for each other, resulting in errors. If this is attempted now, the record creation will fail with a "Record conflict" message.
- Previously, NS and CNAME records could be created for each other, resulting in errors when the zone file gets rendered. If this is attempted now, the record creation will fail with a "Record conflict" message.

@sagesyr sagesyr merged commit 21b4352 into development Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants