[Update] NodeBalancer Config with ProxyProtocol #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspsk
suggested changes
Sep 1, 2020
| enough for it to be considered unhealthy and taken out of rotation. | ||
| example: true | ||
| x-linode-cli-display: 6 | ||
| proxy_protocol: |
There was a problem hiding this comment.
@hzoppetti it accepts "v1", "v2", and "none", so it is not nullable
added 2 commits
September 1, 2020 11:58
aspsk
suggested changes
Sep 1, 2020
openapi.yaml
Outdated
| enables the termination of TCP connections. | ||
|
|
||
|
|
||
| Linode NodeBalancers supports two versions, `v1` and `v2`. `v1` is human readable |
There was a problem hiding this comment.
Another comment. Comparing this to other descriptions in the same section (e.g. stickiness) , this is better be formatted as
- If set to
noneNodeBalancer doesn't send any auxiliary data over TCP connections - If set to
v1the version 1 (human readable) of ProxyProtocol is used - If set to
v2the version 2 (binary) of ProxyProtocol is used
|
|
||
| If ommited from the configuration, the default is `none`. | ||
| type: string | ||
| enum: |
There was a problem hiding this comment.
none should come first (compare with other items, e.g., stickiness)
added 2 commits
September 1, 2020 14:41
aspsk
approved these changes
Sep 1, 2020
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
…os-0.21.1 Bump axios from 0.19.0 to 0.21.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated NodeBalancer config to include ProxyProtocol