[New] Payment Method Add (POST /account/payment-methods) #472
Conversation
bbiggerr
commented
Jun 24, 2021
bbiggerr
commented
- Deprecate Credit Card Add/Edit (POST /account/credit-card)
| To use this endpoint, you must have a valid `zip` entered for your Account. | ||
| Use the Account Update ([PUT /account](/docs/api/account/#account-update)) | ||
| endpoint to enter a new zip code. | ||
| Adds a credit card Payment Method to your account and sets it as the default method. |
There was a problem hiding this comment.
In this comment, it is stated "and sets it as the default method"
However, in another edit below, it states "with the option to set it as the default method."
This should be clarified to the correct statement in whichever place is incorrect.
There was a problem hiding this comment.
This describes the behavior of the deprecated POST /account/credit-card endpoint, which takes in a different request body that doesn't include an is_default field, so it currently sets the payment method as the default automatically in the backend.
| - Account | ||
| summary: Payment Method Add | ||
| description: | | ||
| Adds a Payment Method to your Account with the option to set it as the default method. |
There was a problem hiding this comment.
Here is the other line from the comment above
openapi.yaml
Outdated
| maxLength: 4 | ||
| format: digits | ||
| description: > | ||
| CVV (Card Verification Value) of the credit card, typically found on the back of the card. **** |
There was a problem hiding this comment.
What are the four asterisks here for?
There was a problem hiding this comment.
A placeholder that I forgot to remove! Removing now...
| To use this endpoint, you must have a valid `zip` entered for your Account. | ||
| Use the Account Update ([PUT /account](/docs/api/account/#account-update)) | ||
| endpoint to enter a new zip code. |
There was a problem hiding this comment.
This bit is still valid and this endpoint will still report an error if the listed zip is not valid. Should we keep it?
There was a problem hiding this comment.
I reworded this a bit in the Payment Method Add description to be a bit broader. Agreed that this bit is still valid -- updating that description to be specific about requiring a valid zip as well.
Fix date for Validation 0.6.0
5 participants
