[New] Managed Databases #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshizzle
requested review from
Dorthu,
adammohammed,
bavedarnow and
yoshizzle
yoshizzle
requested changes
Feb 11, 2022
alsaihn
reviewed
Feb 14, 2022
alsaihn
reviewed
Feb 14, 2022
alsaihn
approved these changes
Feb 23, 2022
yoshizzle
requested changes
Feb 23, 2022
Collaborator
yoshizzle
left a comment
yoshizzle
left a comment
There was a problem hiding this comment.
There was also a comment in the go/no-go about being explicit to customers that the secondary hostname (for private IP/within DC traffic) is publically viewable/accessible? I think Matt has more info on that but it should absolutely be included.
openapi.yaml
Outdated
| - $ref: '#/components/parameters/pageOffset' | ||
| - $ref: '#/components/parameters/pageSize' | ||
| description: | | ||
| Display information for a single Managed Database engine type. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Display information for a single Managed Database engine type. | |
| Display information for a single Managed Database engine type and version. |
openapi.yaml
Outdated
| beta. | ||
| responses: | ||
| '200': | ||
| description: Returns information for a single Managed Database engine. |
Collaborator
There was a problem hiding this comment.
Suggested change
| description: Returns information for a single Managed Database engine. | |
| description: Returns information for a single Managed Database engine and version. |
yoshizzle
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.